Bug 36785 - Tagging: Resolve warning about unrecognized biblionumber
Summary: Tagging: Resolve warning about unrecognized biblionumber
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Marcel de Rooy
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-06 08:53 UTC by Marcel de Rooy
Modified: 2024-07-25 11:11 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06
Circulation function:

Attachments
Bug 36785: Do not pass biblionumber to get_approval_rows (1.48 KB, patch)
2024-05-06 09:16 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 36785: Typo unreconized and bilbio in tags code (2.08 KB, patch)
2024-05-06 09:16 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 36785: Do not pass biblionumber to get_approval_rows (1.50 KB, patch)
2024-05-15 08:35 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 36785: Typo unreconized and bilbio in tags code (2.11 KB, patch)
2024-05-15 08:35 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-05-06 08:53:21 UTC 
The warning actually contains a typo:
[2024/05/04 18:07:29] [WARN] get_approval_rows received unreconized argument key 'biblionumber'. at /usr/share/koha/opac/opac-tags.pl line 336.

Where does it come from? Apparently by adding a biblionumber to the URL parameters.

opac-tags does silently seem to ignore it.
Note that you can see the tags on a specific biblionumber on opac-detail.

Small fix coming.
Comment 1 Marcel de Rooy 2024-05-06 09:16:45 UTC 
Created attachment 166188 [details] [review]
Bug 36785: Do not pass biblionumber to get_approval_rows

Resolve:
[WARN] get_approval_rows received unreconized argument key 'biblionumber'. at /usr/share/koha/opac/opac-tags.pl line 336.

Test plan:
Visit opac-tags.pl?biblionumber=SOME_NUMBER
With this patch, you should no longer find a warning in the logs.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-05-06 09:16:47 UTC 
Created attachment 166189 [details] [review]
Bug 36785: Typo unreconized and bilbio in tags code

Test plan:
Look at the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2024-05-06 09:17:06 UTC 
Trivial: Self SO
Comment 4 Martin Renvoize (ashimema) 2024-05-15 08:35:42 UTC 
Created attachment 166755 [details] [review]
Bug 36785: Do not pass biblionumber to get_approval_rows

Resolve:
[WARN] get_approval_rows received unreconized argument key 'biblionumber'. at /usr/share/koha/opac/opac-tags.pl line 336.

Test plan:
Visit opac-tags.pl?biblionumber=SOME_NUMBER
With this patch, you should no longer find a warning in the logs.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-05-15 08:35:44 UTC 
Created attachment 166756 [details] [review]
Bug 36785: Typo unreconized and bilbio in tags code

Test plan:
Look at the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Katrin Fischer 2024-05-17 08:37:44 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-05-29 13:13:38 UTC 
Pushed to 23.11.x for 23.11.06
Comment 8 Wainui Witika-Park 2024-07-15 05:56:36 UTC 
Does this need to be backported to 23.05.x?