Summary: | Fix mistake in database column descriptions for statistics table | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | David Nind <david> |
Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, lucas, magnus |
Version: | unspecified | Keywords: | rel_22_11_candidate, rel_23_05_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the descriptions for the statistics database columns, used in guided reports, (it is a follow-up to bug 32312):
- The descriptions for the statistics section columns now display as intended.
- It adds a description for the interface column (a new column added after the original bug).
|
Version(s) released in: |
24.05.00,23.11.06
|
Circulation function: | |||
Bug Depends on: | 32312 | ||
Bug Blocks: | |||
Attachments: |
Bug 36796: (follow-up) Fix column descriptions for the statistics table
Bug 36796: (follow-up) Fix column descriptions for the statistics table |
Description
Katrin Fischer
2024-05-06 14:41:27 UTC
Created attachment 166238 [details] [review] Bug 36796: (follow-up) Fix column descriptions for the statistics table This follow-up to bug 32312 fixes the descriptions for the statistics database columns, used in guided reports. It removes the duplicate statistics section in Koha/Database/Columns.pm so that descriptions are displayed for all columns, as originally intended. It also adds a description for the interface column (a new column added after the original patch was pushed). Test plan: 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that some columns have descriptions and some don't: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Type / statistics.type Item number / statistics.itemnumber Item type / statistics.itemtype statistics.other statistics.location Borrower number / statistics.borrowernumber statistics.ccode statistics.categorycode statistics.interface 5. Apply the patch. 6. Restart all the things (restart_all). 7. Repeat steps 1 to 4. 8. Scroll down to the statistics table section again and note that all columns now have descriptions: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Transaction type / statistics.type SIP mode / statistics.other Item number / statistics.itemnumber Koha item type / statistics.itemtype Shelving location / statistics.location Borrower number / statistics.borrowernumber Collection / statistics.ccode Patron category / statistics.categorycode Interface / statistics.interface 9. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Created attachment 166279 [details] [review] Bug 36796: (follow-up) Fix column descriptions for the statistics table This follow-up to bug 32312 fixes the descriptions for the statistics database columns, used in guided reports. It removes the duplicate statistics section in Koha/Database/Columns.pm so that descriptions are displayed for all columns, as originally intended. It also adds a description for the interface column (a new column added after the original patch was pushed). Test plan: 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that some columns have descriptions and some don't: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Type / statistics.type Item number / statistics.itemnumber Item type / statistics.itemtype statistics.other statistics.location Borrower number / statistics.borrowernumber statistics.ccode statistics.categorycode statistics.interface 5. Apply the patch. 6. Restart all the things (restart_all). 7. Repeat steps 1 to 4. 8. Scroll down to the statistics table section again and note that all columns now have descriptions: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Transaction type / statistics.type SIP mode / statistics.other Item number / statistics.itemnumber Koha item type / statistics.itemtype Shelving location / statistics.location Borrower number / statistics.borrowernumber Collection / statistics.ccode Patron category / statistics.categorycode Interface / statistics.interface 9. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 |