There are entries missing for the statistics table. How to test: * Add a new guided report * Select module circulation * Verify that statistics is missing some descriptions, only showing the database value
Created attachment 144415 [details] [review] Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com>
For the statistics.other description: 1. C4/Stats.pm and C4/Circulation.pm indicate that the other field is used to record "sipmode". 2. The database schema comment is "used by SIP". I used the description 'SIP mode', although I'm not sure exactly what this means or records for a SIP transaction. I tried a checkout and a check in using SIP, but it didn't record anything additional in the column.
Created attachment 144532 [details] [review] Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 145875 [details] [review] Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks David, Passing QA
Please rebase.
Created attachment 158037 [details] [review] Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to oldstable for 22.11.x
Something wrong here, statistics was present already. 245 statistics => { 246 "datetime" => __("Statistics date and time"), 247 "branch" => __("Library"), 248 "value" => __("Value"), 249 "type" => __("Transaction type"), 250 "other" => __("SIP mode"), 251 "itemnumber" => __("Item number"), 252 "itemtype" => __("Koha item type"), 253 "location" => __("Shelving location"), 254 "borrowernumber" => __("Borrower number"), 255 "ccode" => __("Collection"), 256 "categorycode" => __("Patron category"), 257 }, 302 statistics => { 303 "borrowernumber" => __("Borrower number"), 304 "branch" => __("Library"), 305 "datetime" => __("Statistics date and time"), 306 "itemnumber" => __("Item number"), 307 "itemtype" => __("Itemtype"), 308 "other" => __(""), 309 "type" => __("Type"), 310 "value" => __("Value"), 311 }, In this second block "other" is getting __("") which leads to displaying the header of the po file when using a translated interface.
Maybe a merge conflict? This has already been released, we should move to a separate bug.
Bug 36796 - Fix mistake in database column descriptions for statistics table