Summary: | Cannot hide "Protected" field via BorrowerUnwantedField system preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Emmi Takkinen <emmi.takkinen> |
Component: | Patrons | Assignee: | Emmi Takkinen <emmi.takkinen> |
Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, fridolin.somers, gmcharlt, kyle.m.hall, kyle, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Attachments: |
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref
Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref |
Description
Emmi Takkinen
2024-05-10 05:29:56 UTC
Created attachment 166488 [details] [review] Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy Created attachment 166586 [details] [review] Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Created attachment 166661 [details] [review] Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Passing QA here. Would be nice to make this field work with BorrowerMandatory also. I filed a bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36848 Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Not needed in 23.05.x. |