Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected" To reproduce: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or edit existing one. => Note that "Protected" is still displayed in the form.
Created attachment 166488 [details] [review] Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy
Created attachment 166586 [details] [review] Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 166661 [details] [review] Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Passing QA here. Would be nice to make this field work with BorrowerMandatory also. I filed a bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36848
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Not needed in 23.05.x.