|
Description
Jonathan Druart
2024-05-22 12:42:22 UTC
Created attachment 167028 [details] [review] Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Marcel, any ideas about how to remove the remaining warning? The item with itemnumber=11 does not even exist in the DB... (In reply to Jonathan Druart from comment #2) > Marcel, any ideas about how to remove the remaining warning? > > The item with itemnumber=11 does not even exist in the DB... Shouldnt we just add a sample item here? This $transfer is unused ?? Created attachment 167040 [details] [review] Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 167041 [details] [review] Bug 36924: (follow-up) Remove unused $transfer Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #6) > Created attachment 167041 [details] [review] [review] > Bug 36924: (follow-up) Remove unused $transfer > > Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> This is what I've tried first but actually I'm my understanding we are removing the test. We want to make sure it is still working if a transfer exists. (In reply to Jonathan Druart from comment #7) > (In reply to Marcel de Rooy from comment #6) > > Created attachment 167041 [details] [review] [review] [review] > > Bug 36924: (follow-up) Remove unused $transfer > > > > Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > > This is what I've tried first but actually I'm my understanding we are > removing the test. We want to make sure it is still working if a transfer > exists. Having another look. But looked like it didnt make much sense.. (In reply to Jonathan Druart from comment #7) > (In reply to Marcel de Rooy from comment #6) > > Created attachment 167041 [details] [review] [review] [review] > > Bug 36924: (follow-up) Remove unused $transfer > > > > Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > > This is what I've tried first but actually I'm my understanding we are > removing the test. We want to make sure it is still working if a transfer > exists. We load the records in a mocked Zebra, but they do not exist in db. Now we are adding a transfer to an item that is not there. Scrolling thru C4/Search, I am wondering if we do not have other calls that miss a referenced record too (biblio or item etc). So if you want to really fix this, you will need to add some items and manipulate the marcresults that you pass to searchResults and update those itemnumbers. I think that the test in its current form has very limited value (in view of the mocks and bad data). Fixing that is kind of advanced hacking. I opt for removing it. Will remove my follow-up for now. We should certainly not update TestBuilder for this! We could hide the warning but it is useless imo. I agree that it's too time consuming to adjust this fragile test and that we can remove it. However we should adjust the code around. Removing the test entirely and the comment? (In reply to Jonathan Druart from comment #10) > I agree that it's too time consuming to adjust this fragile test and that we > can remove it. However we should adjust the code around. Removing the test > entirely and the comment? Yes, the immediate context too. Created attachment 167064 [details] [review] Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" We are removing entirely the badly written test. Created attachment 167067 [details] [review] Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Created attachment 167068 [details] [review] Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" We are removing entirely the badly written test. Signed-off-by: David Nind <david@davidnind.com> Created attachment 167070 [details] [review] Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 167071 [details] [review] Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" We are removing entirely the badly written test. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note: We cannot test this properly when the search index refers to biblios and items that do not exist in the database. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |