Summary: | Cannot delete a fund or a currency | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa <emily.lamancusa> |
Component: | Acquisitions | Assignee: | Emily Lamancusa <emily.lamancusa> |
Status: | Pushed to main --- | QA Contact: | Lucas Gass <lucas> |
Severity: | major | ||
Priority: | P5 - low | CC: | lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37090 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Bug Depends on: | |||
Bug Blocks: | 36192 | ||
Attachments: |
Bug 37089: cud-delete_confirm should not be cud
Bug 37089: cud-delete_confirm should not be cud Bug 37089: cud-delete_confirm should not be cud |
Description
Emily Lamancusa
2024-06-14 14:02:01 UTC
Created attachment 167715 [details] [review] Bug 37089: cud-delete_confirm should not be cud Adjust aqbudgets.pl and currency.pl to check for the correct op value To test: Part 1 - Delete a fund 1. Go to Acquisitions > Funds 2. Try to delete a fund --> Confirmation page shows fund name as '' and fund amount as 0.00 3. Click "Yes, delete this fund" --> The fund is still there Part 2 - Delete a currency 3. Go to Acquisitions > Currencies 4. Try to delete a currency --> Confirmation shows empty values for currency and rate 5. Click, "Yes, delete this currency" --> An error message appears and the currency is not deleted 6. Apply patch and restart_all 7. Repeat steps 1-5 --> Confirmation pages display correct information, and deletions occur successfully Created attachment 167717 [details] [review] Bug 37089: cud-delete_confirm should not be cud Adjust aqbudgets.pl and currency.pl to check for the correct op value To test: Part 1 - Delete a fund 1. Go to Acquisitions > Funds 2. Try to delete a fund --> Confirmation page shows fund name as '' and fund amount as 0.00 3. Click "Yes, delete this fund" --> The fund is still there Part 2 - Delete a currency 3. Go to Acquisitions > Currencies 4. Try to delete a currency --> Confirmation shows empty values for currency and rate 5. Click, "Yes, delete this currency" --> An error message appears and the currency is not deleted 6. Apply patch and restart_all 7. Repeat steps 1-5 --> Confirmation pages display correct information, and deletions occur successfully Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 167751 [details] [review] Bug 37089: cud-delete_confirm should not be cud Adjust aqbudgets.pl and currency.pl to check for the correct op value To test: Part 1 - Delete a fund 1. Go to Acquisitions > Funds 2. Try to delete a fund --> Confirmation page shows fund name as '' and fund amount as 0.00 3. Click "Yes, delete this fund" --> The fund is still there Part 2 - Delete a currency 3. Go to Acquisitions > Currencies 4. Try to delete a currency --> Confirmation shows empty values for currency and rate 5. Click, "Yes, delete this currency" --> An error message appears and the currency is not deleted 6. Apply patch and restart_all 7. Repeat steps 1-5 --> Confirmation pages display correct information, and deletions occur successfully Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> It looks like we still got quite a few of "cud-delete-confirm" - should we check those systematically? Pushed for 24.11! Well done everyone, thank you! (In reply to Katrin Fischer from comment #4) > It looks like we still got quite a few of "cud-delete-confirm" - should we > check those systematically? I agree! That was my goal here as well. :) I actually do have a list that I've been working through (pulled by git grep). The others will take a bit more attention because they *don't* seem to break functionality. I just filed bug 37152 with the list and what I've tested so far. (In reply to Emily Lamancusa from comment #6) > (In reply to Katrin Fischer from comment #4) > > It looks like we still got quite a few of "cud-delete-confirm" - should we > > check those systematically? > > I agree! That was my goal here as well. :) I actually do have a list that > I've been working through (pulled by git grep). The others will take a bit > more attention because they *don't* seem to break functionality. I just > filed bug 37152 with the list and what I've tested so far. Awesome, thanks Emily! |