Bug 37080 - Cannot delete a MARC bibliographic framework or authority type
Summary: Cannot delete a MARC bibliographic framework or authority type
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Phil Ringnalda
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 36192
Blocks:
  Show dependency treegraph
 
Reported: 2024-06-12 19:38 UTC by David Nind
Modified: 2024-06-21 13:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00


Attachments
Bug 37080: Cannot delete MARC bibliographic frameworks or authority types (2.46 KB, patch)
2024-06-13 02:43 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 37080: Cannot delete MARC bibliographic frameworks or authority types (2.51 KB, patch)
2024-06-13 09:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 37080: Cannot delete MARC bibliographic frameworks or authority types (2.58 KB, patch)
2024-06-14 10:53 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2024-06-12 19:38:52 UTC
On current main (and 24.05) you cannot delete a MARC bibliographic framework.

Reported on chat (13 June 2024) for 24.05.00 and reproduced on main.

Steps to reproduce:
1. Go to Koha administration > Catalog > MARC bibliographic frameworks.
2. For a framework, select Actions > Delete.
3. Message displayed: "Confirm deletion of framework '' ()?" (with options under this - "Yes, delete this framework" and "No, do not delete") (note that the URL has the framework code /cgi-bin/koha/admin/biblio_framework.pl?op=delete_confirm&frameworkcode=ACQ)
4. Click "Yes, delete this framework".
5. Error message displayed: "An error occurred when deleting this framework. Check the logs for details."
6. Nothing in the logs that seems of any help (/var/logs/koha/kohadev/* - where kohadev is the instance name).

Other observations:
1. If you create a new framework (without adding any MARC structure) and attempt to delete, you get the same error. So not related records using the framework. 
2. No JavaScript or other browser console errors using the browser's web development tools.
Comment 1 Phil Ringnalda 2024-06-13 02:43:33 UTC
Created attachment 167680 [details] [review]
Bug 37080: Cannot delete MARC bibliographic frameworks or authority types

The scripts for managing both bib and authority frameworks are now expecting
an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a
page asking if you are sure. The scripts just need to expect the op they are
actually getting, delete_confirm.

Test plan:
 1. Administration - MARC bibliographic framework - New framework
 2. Give the framework any code and description and Submit
 3. Actions menu for your new framework - Delete
 4. Note the message says 'Confirm deletion of framework '' ()?" rather than
    having the code and description included.
 5. Click Yes, note that deleting failed
 6. Administration - Authority types - New authority type
 7. Give the authority type any type and description and Submit
 8. Actions menu for your authority type - Delete
 9. Note the message again says '' () rather than 'desc' (FOO)
10. Click yes, note that deleting failed
11. Finally! Apply patch, reset_all
12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than
    '' (), and that deleting works.
Comment 2 David Nind 2024-06-13 09:22:36 UTC
Created attachment 167682 [details] [review]
Bug 37080: Cannot delete MARC bibliographic frameworks or authority types

The scripts for managing both bib and authority frameworks are now expecting
an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a
page asking if you are sure. The scripts just need to expect the op they are
actually getting, delete_confirm.

Test plan:
 1. Administration - MARC bibliographic framework - New framework
 2. Give the framework any code and description and Submit
 3. Actions menu for your new framework - Delete
 4. Note the message says 'Confirm deletion of framework '' ()?" rather than
    having the code and description included.
 5. Click Yes, note that deleting failed
 6. Administration - Authority types - New authority type
 7. Give the authority type any type and description and Submit
 8. Actions menu for your authority type - Delete
 9. Note the message again says '' () rather than 'desc' (FOO)
10. Click yes, note that deleting failed
11. Finally! Apply patch, reset_all
12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than
    '' (), and that deleting works.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-06-13 09:23:25 UTC
Thanks Phil for creating a patch so quickly!
Comment 4 David Nind 2024-06-13 21:16:49 UTC
Can confirm that the patch fixes the issue for both MARC frameworks and authority types.
Comment 5 Martin Renvoize 2024-06-14 10:53:43 UTC
Created attachment 167711 [details] [review]
Bug 37080: Cannot delete MARC bibliographic frameworks or authority types

The scripts for managing both bib and authority frameworks are now expecting
an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a
page asking if you are sure. The scripts just need to expect the op they are
actually getting, delete_confirm.

Test plan:
 1. Administration - MARC bibliographic framework - New framework
 2. Give the framework any code and description and Submit
 3. Actions menu for your new framework - Delete
 4. Note the message says 'Confirm deletion of framework '' ()?" rather than
    having the code and description included.
 5. Click Yes, note that deleting failed
 6. Administration - Authority types - New authority type
 7. Give the authority type any type and description and Submit
 8. Actions menu for your authority type - Delete
 9. Note the message again says '' () rather than 'desc' (FOO)
10. Click yes, note that deleting failed
11. Finally! Apply patch, reset_all
12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than
    '' (), and that deleting works.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2024-06-14 10:54:01 UTC
Thanks for the quick correction here.
Comment 7 Emily Lamancusa 2024-06-14 13:58:20 UTC
Thanks, all!

Looks like there are a few more pages where this correction needs to be made...filing additional bugs.
Comment 8 Katrin Fischer 2024-06-21 13:04:37 UTC
Pushed for 24.11!

Well done everyone, thank you!