Bug 37090 - Cannot delete an EDI account
Summary: Cannot delete an EDI account
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Emily Lamancusa (emlam)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 36192
  Show dependency tree / graph
 
Reported: 2024-06-14 14:15 UTC by Emily Lamancusa (emlam)
Modified: 2024-07-26 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the EDI accounts page (Acquisitions > Administration (when EDIFACT is enabled)) so that accounts can be deleted. After the CSRF changes in 24.05 to improve form security, the 'Delete' action for an EDI account no longer worked.
Version(s) released in:
24.11.00,24.05.02
Circulation function:

Attachments
Bug 37090: Correct op parameter in edi_accounts.pl (1.09 KB, patch)
2024-06-14 14:19 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Bug 37090: Correct op parameter in edi_accounts.pl (1.17 KB, patch)
2024-06-14 16:03 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2024-06-14 14:15:55 UTC 
To reproduce:
1. Go to Acquisitions > EDI Accounts
2. Create an EDI account if one is not already there
3. Try to delete the EDI account
--> Page refreshes and nothing happens
Comment 1 Emily Lamancusa (emlam) 2024-06-14 14:19:52 UTC 
Created attachment 167716 [details] [review]
Bug 37090: Correct op parameter in edi_accounts.pl

To test:
1. Go to Acquisitions > EDI Accounts
2. Create an EDI account if one is not already there
3. Try to delete the EDI account
--> Page refreshes and nothing happens
4. Apply patch, restart_all, and refresh the page
5. Try to delete the EDI account again
--> A confirmation page displays with correct information
6. Click "Yes, delete"
--> The EDI account is deleted
Comment 2 Matt Blenkinsop 2024-06-14 16:03:53 UTC 
Created attachment 167748 [details] [review]
Bug 37090: Correct op parameter in edi_accounts.pl

To test:
1. Go to Acquisitions > EDI Accounts
2. Create an EDI account if one is not already there
3. Try to delete the EDI account
--> Page refreshes and nothing happens
4. Apply patch, restart_all, and refresh the page
5. Try to delete the EDI account again
--> A confirmation page displays with correct information
6. Click "Yes, delete"
--> The EDI account is deleted

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Katrin Fischer 2024-06-21 11:59:44 UTC 
Accidentally grabbed this one, but now that it's tested, I am keeping it ;)
Comment 4 Katrin Fischer 2024-06-21 13:04:43 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-07-18 18:08:33 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 6 Fridolin Somers 2024-07-19 08:33:59 UTC 
Full CSRF not in 23.11.x
Comment 7 David Nind 2024-07-26 20:42:32 UTC 
No changes to the manual required - this fixes something that was not working.