| Summary: | Cannot delete an EDI account | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Component: | Acquisitions | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37089 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37091 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the EDI accounts page (Acquisitions > Administration (when EDIFACT is enabled)) so that accounts can be deleted. After the CSRF changes in 24.05 to improve form security, the 'Delete' action for an EDI account no longer worked.
|
Version(s) released in: |
24.11.00,24.05.02
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 36192 | ||
| Attachments: |
Bug 37090: Correct op parameter in edi_accounts.pl
Bug 37090: Correct op parameter in edi_accounts.pl |
||
|
Description
Emily Lamancusa (emlam)
2024-06-14 14:15:55 UTC
Created attachment 167716 [details] [review] Bug 37090: Correct op parameter in edi_accounts.pl To test: 1. Go to Acquisitions > EDI Accounts 2. Create an EDI account if one is not already there 3. Try to delete the EDI account --> Page refreshes and nothing happens 4. Apply patch, restart_all, and refresh the page 5. Try to delete the EDI account again --> A confirmation page displays with correct information 6. Click "Yes, delete" --> The EDI account is deleted Created attachment 167748 [details] [review] Bug 37090: Correct op parameter in edi_accounts.pl To test: 1. Go to Acquisitions > EDI Accounts 2. Create an EDI account if one is not already there 3. Try to delete the EDI account --> Page refreshes and nothing happens 4. Apply patch, restart_all, and refresh the page 5. Try to delete the EDI account again --> A confirmation page displays with correct information 6. Click "Yes, delete" --> The EDI account is deleted Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Accidentally grabbed this one, but now that it's tested, I am keeping it ;) Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Full CSRF not in 23.11.x No changes to the manual required - this fixes something that was not working. |