Bug 37109

Summary: Don't provide old claims fields when duplicating acquisitions orders
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: AcquisitionsAssignee: Aleisha Amohia <aleisha>
Status: Needs documenting --- QA Contact: Kyle M Hall (khall) <kyle>
Severity: enhancement    
Priority: P5 - low CC: lucas, martin.renvoize, philip.orr
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This patch stops the unused fields claims_count, claimed_date, received_on and placed_on from being initialised while duplicating an order. The fields no longer exist in the aqorders table and no longer need to be set or passed on.
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 24161    
Bug Blocks: 27063    
Attachments: Bug 37109: Don't initialise claims fields when duplicating acquisitions orders
Bug 37109: Don't initialise claims fields when duplicating acquisitions orders
Bug 37109: Don't initialise claims fields when duplicating acquisitions orders
Bug 37109: Don't initialise claims fields when duplicating acquisitions orders

Description Aleisha Amohia 2024-06-18 03:28:36 UTC
The following fields that used to be in the aqorders table for claims are still initialised when duplicating orders. They aren't stored anywhere so don't cause a problem, but they don't need to be set at all.

* claims_count (dropped in Bug 24161)
* claimed_date (dropped in Bug 24161)
* placed_on (no evidence of this field existing in aqorders)
Comment 1 Aleisha Amohia 2024-06-18 03:33:05 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2024-06-18 03:37:54 UTC
Created attachment 167817 [details] [review]
Bug 37109: Don't initialise claims fields when duplicating acquisitions orders

These fields don't exist in the aqorders table and don't need to be set/passed on.

* claims_count (dropped in Bug 24161)
* claimed_date (dropped in Bug 24161)
* placed_on (no evidence of this field existing in aqorders)
* received_on (no evidence of this field existing in aqorders)

To test:

1. Go to Acquisitions
2. Create a vendor if you don't already have one
3. Create a basket if you don't already have one
4. Add an order to the basket and Save
5. Add another order to the basket, choose "From existing orders (copy)"
6. Continue through the process and confirm you're able to duplicate the order as normal
7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t

Sponsored-by: Catalyst IT
Comment 3 Owen Leonard 2024-06-18 11:50:42 UTC
Created attachment 167822 [details] [review]
Bug 37109: Don't initialise claims fields when duplicating acquisitions orders

These fields don't exist in the aqorders table and don't need to be
set/passed on.

* claims_count (dropped in Bug 24161)
* claimed_date (dropped in Bug 24161)
* placed_on (no evidence of this field existing in aqorders)
* received_on (no evidence of this field existing in aqorders)

To test:

1. Go to Acquisitions
2. Create a vendor if you don't already have one
3. Create a basket if you don't already have one
4. Add an order to the basket and Save
5. Add another order to the basket, choose "From existing orders
   (copy)"
6. Continue through the process and confirm you're able to duplicate the
   order as normal
7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Kyle M Hall (khall) 2024-10-07 16:13:11 UTC
Created attachment 172493 [details] [review]
Bug 37109: Don't initialise claims fields when duplicating acquisitions orders

These fields don't exist in the aqorders table and don't need to be
set/passed on.

* claims_count (dropped in Bug 24161)
* claimed_date (dropped in Bug 24161)
* placed_on (no evidence of this field existing in aqorders)
* received_on (no evidence of this field existing in aqorders)

To test:

1. Go to Acquisitions
2. Create a vendor if you don't already have one
3. Create a basket if you don't already have one
4. Add an order to the basket and Save
5. Add another order to the basket, choose "From existing orders
   (copy)"
6. Continue through the process and confirm you're able to duplicate the
   order as normal
7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-10-21 12:59:44 UTC
I think placed_on refers to aqorders.creationdate and received_on to datereceived, but at the same time you would not want to duplicate these.
Comment 6 Katrin Fischer 2024-10-24 08:49:24 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Philip Orr 2024-11-08 15:34:57 UTC
release notes added
Comment 8 Lucas Gass (lukeg) 2024-11-18 23:03:43 UTC
Enhancement, no 24.05.x backport