At the moment if the basket is still open you can update the bbliographic details of an order or overwrite the existing record via Z39.50, but if you notice that you have used the wrong record, there is no way to fix this. It would be great if it was possible to change the record an order is linked to while the basket is still open. This should explicitly allow to use a record that is already in the catalog. -- There is also a use case here for libraries using standing orders for tracking electronic resources such as series. They usually place the order on the series record. When the volumes arrive they'd like to change it so the acq information is tied to the volume. But without using items (which is not the case here for electronic resources), this is not possible.
Created attachment 167619 [details] [review] Bug 27063: Add modal for linking a basket order to a different record Still WIP
Created attachment 167678 [details] [review] Bug 27063: Add modal for linking a basket order to a different record
Created attachment 167679 [details] [review] Bug 27063: [WIP] Link different record to order from existing records So far this works for * from an existing record * from a suggestion * from a new (empty) record
Created attachment 167783 [details] [review] Bug 27063: Add modal for linking a basket order to a different record
Created attachment 167784 [details] [review] Bug 27063: [WIP] Link different record to order from existing records So far this works for * from an existing record * from a suggestion * from a new (empty) record * from a subscription
Created attachment 167818 [details] [review] Bug 27063: Add modal for linking a basket order to a different record
Created attachment 167819 [details] [review] Bug 27063: [WIP] Link different record to order from existing records So far this works for * from an existing record * from a suggestion * from a new (empty) record * from a subscription * from existing orders (copy) Working on: * from an external source
Created attachment 168049 [details] [review] Bug 27063: Add modal for linking a basket order to a different record
Created attachment 168050 [details] [review] Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology
Created attachment 168571 [details] [review] Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology
Created attachment 168572 [details] [review] Bug 27063: Allow received orders to also be relinked Useful for when the bibliographic records of received orders have been deleted, but we want to keep the ordernumber history/invoice data etc. To test: 1. Add an order to a standing basket 2. Receive the order 3. Once received, delete the record attached to the order 4. Go back to the basket 5. Attempt to relink the order with the deleted record 6. This should work Sponsored-by: Auckland University of Technology
Need to also update the invoice of a relinked order
Created attachment 170123 [details] [review] Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and relinked. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology
Created attachment 170166 [details] [review] Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and relinked. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology
(In reply to Aleisha Amohia from comment #11) > Created attachment 168572 [details] [review] [review] > Bug 27063: Allow received orders to also be relinked > > Useful for when the bibliographic records of received orders have been > deleted, but we want to keep the ordernumber history/invoice data etc. > > To test: > > 1. Add an order to a standing basket > 2. Receive the order > 3. Once received, delete the record attached to the order > 4. Go back to the basket > 5. Attempt to relink the order with the deleted record > 6. This should work > This one does not work. But I do not understand why it is necessary. We already store the biblionumber of the deleted record in the orderline and since Bug 10758 we display the title of this deleted record. So we already keep the ordernumber history/invoice data etc.
Created attachment 170487 [details] [review] Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology
Created attachment 170488 [details] [review] Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology
Created attachment 170692 [details] [review] Bug 27063: Add modal for linking a basket order to a different record
Created attachment 170693 [details] [review] Bug 27063: Link different record to order from existing records This patch adds the ability to link an order to a different record. This applies to: * orders in open baskets (not closed) * unreceived orders in standing baskets Orders can be linked: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source To test: 1. Apply the patches and restart services 2. Create a normal basket (do not check 'orders are standing'). Add an order to the basket. 3. Notice there is a 'Link to different record' option in the Modify column. 4. Close the basket. 5. Create another basket, this time do check the 'orders are standing' option. Add two orders to the basket. 6. Click 'Link to different record' for one of the orders. 7. Create a suggestion. Create a subscription. Have a MARC record available to stage/import. 8. Loop through each option, linking: * from an existing record * from a suggestion * from a subscription * from a new (empty) record * from existing orders (copy) * from an external source Make sure that the accounting information is always kept, and just the record details of the order are changed. 9. Go to the vendor page and click 'Receive shipments'. Fill in invoice details. 10. On the receiving page, 'Receive' one of your standing orders. Increment the quantity and finish receiving. 11. Go to the standing basket. Confirm there is no 'Link to different record' option for the received order. Sponsored-by: Auckland University of Technology
Created attachment 170694 [details] [review] Bug 27063: Allow received orders to also be relinked Useful for when the bibliographic records of received orders have been deleted, but we want to keep the ordernumber history/invoice data etc. To test: 1. Add an order to a standing basket 2. Receive the order 3. Once received, delete the record attached to the order 4. Go back to the basket 5. Attempt to relink the order with the deleted record 6. This should work Sponsored-by: Auckland University of Technology
Created attachment 170695 [details] [review] Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology
Created attachment 170696 [details] [review] Bug 27063: Use Bootstrap 5 syntax for modal
The patch no longer applies - getting the SHA1/fake ancestor error. git bz apply 27063 Bug 27063 - Allow changing which record an order is linked to 170692 - Bug 27063: Add modal for linking a basket order to a different record 170693 - Bug 27063: Link different record to order from existing records 170694 - Bug 27063: Allow received orders to also be relinked 170695 - Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement 170696 - Bug 27063: Use Bootstrap 5 syntax for modal Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27063: Add modal for linking a basket order to a different record Applying: Bug 27063: Link different record to order from existing records Applying: Bug 27063: Allow received orders to also be relinked Applying: Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement
Created attachment 174648 [details] [review] Bug 27063: Syspref KeepInvoiceOnOrderRelink and implement This follow-up patch adds a new system preference KeepInvoiceOnOrderRelink. When enabled, relinking a received order will keep the invoice ID of the original order. This is useful for standing orders where the record has been deleted and linked to a new record/order. To test: 1. Enable the system preference KeepInvoiceOnOrderRelink 2. Add an order to a standing basket 3. Receive the order 4. Once received, go to the record and view the Acquisitions details tab. Notice the invoice is linked. 5. Go back to the basket 6. Relink the received order to a different record 7. Go to the record and view the Acquisitions details tab. Notice the invoice has been kept. 8. Repeat the test plan with the system preference KeepInvoiceOnOrderRelink disabled. Notice the invoice is nullified after the order is relinked. Sponsored-by: Auckland University of Technology
Created attachment 174649 [details] [review] Bug 27063: Use Bootstrap 5 syntax for modal