Summary: | Redesign labels home page to match other module home pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Patch doesn't apply --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement changes the label creator home page (Cataloging > Tools > Label creator) so that it shows the links which previously were buried in a dropdown menu.
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | 37222 | ||
Bug Blocks: | 37581 | ||
Attachments: |
Bug 37250: Redesign labels home page to match other module home pages
Bug 37250: Redesign labels home page to match other module home pages Bug 37250: Redesign labels home page to match other module home pages Bug 37250: (follow-up) More improvements to menus Bug 37250: Redesign labels home page to match other module home pages Bug 37250: (follow-up) More improvements to menus |
Description
Owen Leonard
2024-07-03 18:24:47 UTC
Created attachment 168470 [details] [review] Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries I did reset_all after applying the patch and I'm still getting an error when I click on any of the buttons Template process failed: file error - labels-menu.inc: not found at /kohadevbox/koha/C4/Templates.pm line 134 (In reply to Caroline Cyr La Rose from comment #2) > I did reset_all after applying the patch and I'm still getting an error when > I click on any of the buttons > > Template process failed: file error - labels-menu.inc: not found at > /kohadevbox/koha/C4/Templates.pm line 134 I get the same. No CSS changes, so no yarn build required. A restart_all was all that I did after applying the patch. Created attachment 168563 [details] [review] Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries (In reply to David Nind from comment #3) > > Template process failed: file error - labels-menu.inc: not found at > > /kohadevbox/koha/C4/Templates.pm line 134 Sorry, I forgot to commit the new file! Created attachment 168569 [details] [review] Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> (In reply to Owen Leonard from comment #5) > (In reply to David Nind from comment #3) > > > Template process failed: file error - labels-menu.inc: not found at > > > /kohadevbox/koha/C4/Templates.pm line 134 > > Sorry, I forgot to commit the new file! Thanks Owen! I like the updated layout. I have some suggestions, but I think these would probably be better as new bugs: 1. When you are in any of the areas, there is a new sidebar at the top with Label batches, Label layouts, etc: - These are highlighted when you are in that section, but not when you are on the new form for each of them (don't know if it is possible to highlight these in this case) - There is no "Print barcode range" in this new sidebar (see the additional suggestion below) - Should this display when you are just on the label creator page? 2. Dropdown list for +New: change "Layout" to "Label layout" (matches with page heading, and new top sidebar label, and is more consistent with other new items). 3. Print barcode range: as this is not saved, or editable later on, maybe this: - could have it's own button on the label creator home page - could have it's own action button next to +New - I don't think it quite fits under +New 4. Breadcrumbs (and page titles): - New label batches: Label creator > Label batches> New label batch (currently just Batches) - New label layouts: Label creator > Label layouts > New label layouts (currently just Layouts) - New label template: Label creator > Label templates > New label template (currently just Templates) - New printer profile: Label creator > Printer profiles > New printer profiles (currently just Profiles) Testing notes (using KTD): 1. Update the CSS (required for dependent bug): yarn build Created attachment 169307 [details] [review] Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. Created attachment 171067 [details] [review] Bug 37250: Redesign labels home page to match other module home pages This patch changes the labels home page so that it shows the links which previously were buried in a dropdown menu. Generally speaking we shouldn't be using the button toolbar for navigation. To test, apply the patch and go to Cataloging -> Label creator. - You should see links styled like they are on the circulation or cataloging home page. - If you follow any of those links you should see a new menu in the sidebar which has all the navigation items previously in the "Manage" dropdown menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 171068 [details] [review] Bug 37250: (follow-up) More improvements to menus - Add highlighting to new sidebar menu - Make labels more consistent in menus, breadcrumbs, and titles - Add 'Print barcode range' link to the labels home page and sidebar menu. Doesn't seem to apply cleanly now. Maybe due due to Bug 37250. |