Created attachment 170102 [details] Gif showing the behavior of the new buttons Currently the toolbar shown on label creator pages is labeled "New" with a dropdown for all the options (New batch, new layout, etc.) I propose that we make this a split button where the default action of the button changes with the context: If you're on the "Label layouts" page for example, the button says "New label layout" and the secondary button triggers a dropdown with all the options.
Created attachment 170143 [details] [review] Bug 37581: Use split button for label creator "new" operations This patch modifies the "New" menu in the label creator so that it is a split button instead of a simple menu. The primary button area will now be a direct link to creating a new entry for whatever area you are in: batches, labels, templates, or printer profiles. The secondary menu offers all options. To test, apply the patch and go to Cataloging -> Labels. - On the label creator page, you should see a split button in the toolbar. The text label should read "New label batch," and clicking it should take you directly to creation of a new label batch. - Clicking the secondary action of the menu item, the down-arrow, should offer a menu of all the other "New" options. - Confirm that the dropdown menu links all work correctly. - Confirm that as you switch to different sections of the label creator the default "new" action of the toolbar button changes: - In label batches, "New label batch" - In label layouts, "New label layout" - In label templates, "New label template" - In printer profiles, "New printer profiles" - When you're on the "Print profile range" page, the default is "New label batch" because there is no "new" action for that page, and label batch seemed like a sensible default. Sponsored-by: Athens County Public Libraries
I think the "wrong_html_filter at line 20" warning from the QA tool is incorrect in this situation.
Created attachment 170202 [details] [review] Bug 37581: Use split button for label creator "new" operations This patch modifies the "New" menu in the label creator so that it is a split button instead of a simple menu. The primary button area will now be a direct link to creating a new entry for whatever area you are in: batches, labels, templates, or printer profiles. The secondary menu offers all options. To test, apply the patch and go to Cataloging -> Labels. - On the label creator page, you should see a split button in the toolbar. The text label should read "New label batch," and clicking it should take you directly to creation of a new label batch. - Clicking the secondary action of the menu item, the down-arrow, should offer a menu of all the other "New" options. - Confirm that the dropdown menu links all work correctly. - Confirm that as you switch to different sections of the label creator the default "new" action of the toolbar button changes: - In label batches, "New label batch" - In label layouts, "New label layout" - In label templates, "New label template" - In printer profiles, "New printer profiles" - When you're on the "Print profile range" page, the default is "New label batch" because there is no "new" action for that page, and label batch seemed like a sensible default. Sponsored-by: Athens County Public Libraries Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de>
There is a dependency here that is still in "Needs signoff" - moving out of queue for now. Please bring back as soon as this is resolved.