Bug 37311

Summary: Tone down the SMTP servers administration page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: enhancement    
Priority: P5 - low CC: david, dcook, gmcharlt, lucas, ovezina
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This enhancement improves the SMTP servers administration page. It reformats the information section at the top of the page with the current default SMTP server detailsand adds an edit link. For the table listing all the SMTP servers: - "Is default" column: if the server is the default, it is highlighted with a green badge and "Default" in bold (the row is no longer in red and italicised, implying action is required to fix something). - "Debug mode" column: if the server is in debug mode, it is highlighted with a yellow badge and "On" in bold.
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 37311: Tone down the SMTP servers administration page
Bug 37311: Tone down the SMTP servers administration page
Bug 37311: Tone down the SMTP servers administration page
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
Bug 37311: Tone down the SMTP servers administration page
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
Bug 37311: Tone down the SMTP servers administration page
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
Bug 37311: Tone down the SMTP servers administration page
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Description Owen Leonard 2024-07-10 18:01:36 UTC
Information about the current configuration is shown as an informational dialog, and default server and debugging status are highlighted in red as if it were an error needing attention. I think the page could be restyled to convey the information without the implicit demand for action.
Comment 1 Owen Leonard 2024-07-10 18:26:16 UTC
Created attachment 168762 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-07-11 04:28:32 UTC
Created attachment 168774 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2024-09-02 09:42:21 UTC
I don't want to miss something, please rebase!
Comment 4 Owen Leonard 2024-09-05 13:09:05 UTC
Created attachment 171070 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Owen Leonard 2024-09-05 13:09:07 UTC
Created attachment 171071 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.
Comment 6 Olivier Vezina 2024-09-06 19:05:34 UTC
Created attachment 171148 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 7 Olivier Vezina 2024-09-06 19:20:13 UTC
Created attachment 171149 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 8 David Cook 2024-11-13 03:41:45 UTC
Sorry patch doesn't apply due to ye old fake ancestor:

Applying: Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
Comment 9 Owen Leonard 2024-11-13 15:52:48 UTC
Created attachment 174473 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 10 Owen Leonard 2024-11-13 15:54:04 UTC
Created attachment 174474 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 11 Owen Leonard 2024-11-13 15:54:06 UTC
Created attachment 174475 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 12 Lucas Gass (lukeg) 2024-11-22 17:40:06 UTC
Created attachment 174938 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 13 Lucas Gass (lukeg) 2024-11-22 17:40:09 UTC
Created attachment 174939 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 14 Katrin Fischer 2024-12-23 10:09:12 UTC
This took a while, happy to push.
Comment 15 Katrin Fischer 2024-12-23 11:23:20 UTC
Pushed for 25.05!

Well done everyone, thank you!