Bug 37330

Created attachment 168843 [details] [review]
Bug 37330: Add drawcallback if LocalCoverImages

1) Enable LocalCoverImages
2) Visit a biblio:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=294
3) On the actions column, click the arrow and click upload image, submit an image
4) Go back to biblio, notice the image shows for the specific item
5) Disable StaffDetailItemSelection
6) Go back to biblio, notice the image is gone
7) Apply patch. Repeat.

Something weird is going on here for me with item cover images.

Tested on the latest main, with everything up to date for KTD, and clearing browser caches between changes.

Before the patch, the item cover image is NOT showing for the individual item in the holdings table, but is showing for the record cover images.

This is without the patch and after the patch, and with and without StaffDetailItemSelection enabled.

That is (for me), no item cover images are showing for any of the combinations before and after the patch. I've tested before and after in Firefox and Chromium.

I've also tested with combinations of AllowMultipleCovers, LocalCoverImages, OPACLocalCoverImages.

I thought it may have been something with Bug 33526 - Use template wrapper for tabs: bibliographic detail page and Bug 36966 - Fix links for local cover images for items on staff detail page. These are in main, but if I use 24.05.01 I still get the same behavour.

The StaffDetailItemSelection seems to be gone in the current main. I don't know if this voids this patch

I think you might still be able to test it. We removed it, but it defaults to "ON" now.

Created attachment 171519 [details] [review]
Bug 37330: (bug 33526 follow-up) Fix display of cover images for items

The id has been modified by bug 33526. We can simply pass the table
element however.

Test plan:
Have some cover images at item level and notice that they are correctly
displayed on the bibliographic record detail page.

Note that the slider does not work correctly. If you click on the dot
(so if you have several images for an item) the scrollbar is going to
hit the top of the page and the image won't change.
Could be reported separately if not done yet.

Created attachment 171523 [details] [review]
Bug 37330: (bug 33526 follow-up) Fix display of cover images for items

The id has been modified by bug 33526. We can simply pass the table
element however.

Test plan:
Have some cover images at item level and notice that they are correctly
displayed on the bibliographic record detail page.

Note that the slider does not work correctly. If you click on the dot
(so if you have several images for an item) the scrollbar is going to
hit the top of the page and the image won't change.
Could be reported separately if not done yet.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Created attachment 171591 [details] [review]
Bug 37330: (bug 33526 follow-up) Fix display of cover images for items

The id has been modified by bug 33526. We can simply pass the table
element however.

Test plan:
Have some cover images at item level and notice that they are correctly
displayed on the bibliographic record detail page.

Note that the slider does not work correctly. If you click on the dot
(so if you have several images for an item) the scrollbar is going to
hit the top of the page and the image won't change.
Could be reported separately if not done yet.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant