Summary: | Cannot hide columns in ERM tables | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric Garcia <cubingguy714> |
Component: | ERM | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to oldstable --- | QA Contact: | Pedro Amorim <pedro.amorim> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jonathan.field, lucas, martin.renvoize, matt.blenkinsop, ovezina, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
Circulation function: | |||
Bug Depends on: | 33066 | ||
Bug Blocks: | 33484 | ||
Attachments: |
Bug 37395: Fix columns visibility on Vue tables
Bug 37395: Fix columns visibility on Vue tables Bug 37395: Fix columns visibility on Vue tables |
Description
Eric Garcia
2024-07-17 16:05:21 UTC
Created attachment 171925 [details] [review] Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Created attachment 171978 [details] [review] Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 173130 [details] [review] Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 |