To recreate: 1. Administration -> System Preferences 2. Search for ERMModule -> Enable 3. E-resource management -> Agreements -> Configure 4. Check "is hidden by default" on any of the columns 5. Go back to the Agreements table and notice the columns are not hidden 6. Repeat with other tables in ERM
Created attachment 171925 [details] [review] Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.)
Created attachment 171978 [details] [review] Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Created attachment 173130 [details] [review] Bug 37395: Fix columns visibility on Vue tables On bug 33066 we reworked a lot of datatables.js to make the JS function reusable from the Vue component (and especially the KohaTable component). I guess the regression comes from this change, but I am surprised that we didn't catch it when testing. The was a mistake for _dt_visibility, we didn't pass the node. Actually we cannot pass it as we do not have it yet. This "node" variable is only used when bKohaColumnsUseNames is passed (ie. we do not rely on the order of the columns but we need to rely on their data-colname attributes). There is then a limitation here: we cannot use bKohaColumnsUseNames from Vue, but we do not yet. An ideal fix would be too big for now, especially for an hypothetic use case. Test plan: Confirm that the "Columns" button are now back for the tables of the Vue apps (ERM, Preservation) and that the settings are taken into account (hide by default, etc.) Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Does not apply on 23.11.x maybe because of Bug 33568