Bug 37707

Summary: Lead/Trail times should work in combination
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: CirculationAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: ASSIGNED --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrew, dbarden, gmcharlt, kkrueger, kyle
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Crowdfunding goal: 0
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function: Bookings
Bug Depends on: 39584    
Bug Blocks:    
Attachments: Bug 37707: First draft

Description Martin Renvoize (ashimema) 2024-08-22 09:21:24 UTC
Whilst working on the lead/trail time addition to bookings we discussed how they should affect things.

In the end we decided that they should work in combination when placing bookings so the window of unbookable time before a bookings should be the previous bookings 'trail' period + the current bookings 'lead' period.

I've run out of capacity to make that change in the aforementioned bug, so I'm splitting it out here to work on that as a expedient follow-up.

Lets get the core functionality in and then continue to polish it.

A- | TA >|< LB | -B- | TB >|< LC | -C
Comment 1 Martin Renvoize (ashimema) 2025-05-21 13:26:31 UTC
*** Bug 39390 has been marked as a duplicate of this bug. ***
Comment 2 Martin Renvoize (ashimema) 2025-05-22 06:48:35 UTC
Created attachment 182718 [details] [review]
Bug 37707: First draft

This patch adds calculation of pre and post booking days into the
disableDate function.

I'm not sure I like it for display yet, but functionally it works
Comment 3 Andrew Fuerste-Henry 2025-09-15 20:51:57 UTC
I can confirm this works as described -- bookings cannot be created such that the trailing time of one booking intersects with the leading time of the next. The interface grays out dates that cannot be selected and changes the mouse icon to a crossed-out-circle. Martin, what do you still feel is missing in the display here? Our libraries would love to see this functionality in Koha sooner rather than later.
Comment 4 Kristi Krueger 2025-10-01 19:54:59 UTC
We are eager to see this one move forward.
Comment 5 Martin Renvoize (ashimema) 2025-10-24 06:54:46 UTC
I'm still targeting 25.11 for this. There's been a few holdups in terms of getting consistent Cypress tests working upstream of this (I don't want to break existing functionality whilst working on this), and the test infrastructure has been changing multiple times whilst I've been working on that.  There's also a Vue refactor of the current Modal code to make extending it simpler, which Paul has ready to submit.

In short.. It's all just around the corner, but every time I hit it of late, I find the tides have shifted beneath my feet.