| Summary: | Undocument koha-worker --queue elastic_index | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Command-line Utilities | Assignee: | Magnus Enger <magnus> |
| Status: | Pushed to stable --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, phil, robin, sukhmandeep.benipal |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 37787; Undocument koha-worker --queue elastic_index
Bug 37787: Remove mention of elastic_index from POD Bug 37787: Remove mention of elastic_index from POD Bug 37787; Undocument koha-worker --queue elastic_index Bug 37787: Remove mention of elastic_index from POD Bug 37787: Undocument koha-worker --queue elastic_index Bug 37787: Remove mention of elastic_index from POD |
||
|
Description
Magnus Enger
2024-08-30 06:30:54 UTC
Created attachment 170900 [details] [review] Bug 37787; Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. The POD for https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/workers/background_jobs_worker.pl still mentions elastic_index: =item B<--queue> Repeatable. Give the job queues this worker will process. The different values available are: default long_tasks elastic_index Created attachment 171046 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Created attachment 171280 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Created attachment 171281 [details] [review] Bug 37787; Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Created attachment 171282 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Created attachment 173164 [details] [review] Bug 37787: Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 173165 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 |