Documentation for koha-worker --queue elastic_index was added in Bug 36009, and as far as I can tell, that was the right thing to do at the time. Then koha-es-indexer was added in Bug 33108, and after that running both koha-es-indexer and "koha-worker --queue elastic_index" at the same time leads to problems, like only every other elastic_index job getting processed. We should remove the mention of "--queue elastic_index" from the koha-worker docs. (And maybe add a note that only koha-es-indexer should be run.) koha-es-indexer has been introduced to 23.05.00 and 22.11.06, so a fix should not be backported to older versions than that.
Created attachment 170900 [details] [review] Bug 37787; Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running.
The POD for https://git.koha-community.org/Koha-community/Koha/src/branch/main/misc/workers/background_jobs_worker.pl still mentions elastic_index: =item B<--queue> Repeatable. Give the job queues this worker will process. The different values available are: default long_tasks elastic_index
Created attachment 171046 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone
Created attachment 171280 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Created attachment 171281 [details] [review] Bug 37787; Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Created attachment 171282 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Created attachment 173164 [details] [review] Bug 37787: Undocument koha-worker --queue elastic_index To test: - Copy the koha-worker script to the standard location: $ sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker - Check "sudo koha-worker --help" and verify elastic_index is not mentioned in the list of "current queues" - See https://wiki.koha-community.org/wiki/Testing_man_pages for how to check the "man" page. elastic_index should not be mentioned in the list of "Current queues". - Both places aboce should have a note about elastic_index not being active when koha-es-indexer is running. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 173165 [details] [review] Bug 37787: Remove mention of elastic_index from POD After the introduction of misc/workers/es_indexer_daemon.pl, misc/workers/background_jobs_worker.pl should not handle the elastic_index queue. But the latter script still mentions this queue in the POD. This patch removes that mention. To test: - Run perldoc misc/workers/background_jobs_worker.pl - Verify "elastic_index" is mentioned under --queue - Apply this patch - Run perldoc again and verify the mention of "elastic_index" is gone Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.11! Well done everyone, thank you!