Bug 37859

Summary:	Tabs for record comments are in plain text (related to Bootstrap 5 update)
Product:	Koha	Reporter:	David Nind <david>
Component:	Tools	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	jonathan.druart, lucas, sukhmandeep.benipal
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes the tab headings for patron comments (Tools > Patrons and circulation > Comments), so that they are now standard tabs instead of plain text links. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)	Version(s) released in:	24.11.00
Circulation function:
Bug Depends on:	35402
Bug Blocks:
Attachments:	Bug 37859: Fix style of tabs on comment review page Bug 37859: Fix style of tabs on comment review page Bug 37859: Fix style of tabs on comment review page

Description David Nind 2024-09-06 19:54:50 UTC

When viewing patron comments on records, the tabs are plain text links instead of the standard tabbed style.

To replicate:
1. Go to Tools > Patrons and circulation > Comments.
2. Note that tab headings are plain text links, instead of the standard tabbed style.

I think this is similar to bug 37752 and bug 37753.

Comment 1 Owen Leonard 2024-09-09 11:59:06 UTC

Created attachment 171192 [details] [review]
Bug 37859: Fix style of tabs on comment review page

This patch corrects the tab markup on the comment review page. These
tabs are just links styled as tabs -- there isn't any JS tab swapping.
This kind of "static" tab markup wasn't handled by the tabs WRAPPER
work.

To test you should have some comments data in your system:

 - Go to Administration -> System preferences and enable the
   "OPACComments" preference.
 - Log in to the OPAC and search for a bibliographic record.
 - View the detail page for the record and click the "Comments" tab.
 - Click "Post your comments on this title."
 - Enter some text in the review box and submit.

In the staff interface, go to Tools -> Comments.

 - You should see two tabs: "Approved comments" and "Comments awaiting
   moderation."
 - Confirm that the tabs look correct.
 - Approve one or more comments and confirm that the tabs work correctly
   to switch views.

Comment 2 Sukhmandeep 2024-09-09 14:14:01 UTC

Created attachment 171203 [details] [review]
Bug 37859: Fix style of tabs on comment review page

This patch corrects the tab markup on the comment review page. These
tabs are just links styled as tabs -- there isn't any JS tab swapping.
This kind of "static" tab markup wasn't handled by the tabs WRAPPER
work.

To test you should have some comments data in your system:

 - Go to Administration -> System preferences and enable the
   "OPACComments" preference.
 - Log in to the OPAC and search for a bibliographic record.
 - View the detail page for the record and click the "Comments" tab.
 - Click "Post your comments on this title."
 - Enter some text in the review box and submit.

In the staff interface, go to Tools -> Comments.

 - You should see two tabs: "Approved comments" and "Comments awaiting
   moderation."
 - Confirm that the tabs look correct.
 - Approve one or more comments and confirm that the tabs work correctly
   to switch views.

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>

Comment 3 David Nind 2024-09-09 19:47:14 UTC

Thanks Owen and Sukhmandeep!

Comment 4 Jonathan Druart 2024-09-11 13:02:46 UTC

Created attachment 171306 [details] [review]
Bug 37859: Fix style of tabs on comment review page

This patch corrects the tab markup on the comment review page. These
tabs are just links styled as tabs -- there isn't any JS tab swapping.
This kind of "static" tab markup wasn't handled by the tabs WRAPPER
work.

To test you should have some comments data in your system:

 - Go to Administration -> System preferences and enable the
   "OPACComments" preference.
 - Log in to the OPAC and search for a bibliographic record.
 - View the detail page for the record and click the "Comments" tab.
 - Click "Post your comments on this title."
 - Enter some text in the review box and submit.

In the staff interface, go to Tools -> Comments.

 - You should see two tabs: "Approved comments" and "Comments awaiting
   moderation."
 - Confirm that the tabs look correct.
 - Approve one or more comments and confirm that the tabs work correctly
   to switch views.

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 5 Katrin Fischer 2024-09-13 10:08:19 UTC

Pushed for 24.11!

Well done everyone, thank you!