Description
Caroline Cyr La Rose
2024-09-12 18:42:44 UTC
I also noticed there are spaces missing when viewing the updated ticket. - Between the assignee's name and the description (I feel like those two things should not be on the same line?) - Between the "Private" and the text of the update - Between the date of the update and the assignee I found another one. If you resolve the concern, and show the resolved concerns in the table, there is no space between the name/link of the staff and the date. Created attachment 173650 [details] [review] Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Created attachment 173651 [details]
24.05 Modal
The content of attachment 173651 [details] has been deleted
Created attachment 173652 [details]
Modal using flex
Created attachment 173653 [details]
24.05 Modal (before bootstrap 5)
Created attachment 173659 [details] [review] Bug 37910: Minor improvements to comment form Created attachment 173660 [details] [review] Bug 37910: Sync fixes to detail page Created attachment 173661 [details] [review] Bug 37910: Sync fixes to detail page This fixes all the issues Caroline identified. However, there is one new thing that I noted: 1. On the details page for a record > Concerns > Details column: . Before the patch: the title and number of comments/updates are a link (I think it is just one link): clicking either of these opens the details view for the catalog concern (as expected) . After the patch: the details view doesn't open 2. On the catalog concerns listing (Cataloging > Catalog concerns): . Before the patch: the title and number of comments/updates are separate links - clicking on them doesn't open the details view . After the patch: same behavour as before the patch, no details view opens (In reply to David Nind from comment #11) > This fixes all the issues Caroline identified. > > However, there is one new thing that I noted: > > 1. On the details page for a record > Concerns > Details column: > . Before the patch: the title and number of comments/updates are a link > (I think it is just one link): clicking either of these opens the details > view for the catalog concern (as expected) > . After the patch: the details view doesn't open > > 2. On the catalog concerns listing (Cataloging > Catalog concerns): > . Before the patch: the title and number of comments/updates are separate > links - clicking on them doesn't open the details view > . After the patch: same behavour as before the patch, no details view > opens This is fixed by bug 37912. Created attachment 173692 [details] [review] Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Signed-off-by: David Nind <david@davidnind.com> Created attachment 173693 [details] [review] Bug 37910: Minor improvements to comment form Signed-off-by: David Nind <david@davidnind.com> Created attachment 173694 [details] [review] Bug 37910: Sync fixes to detail page Signed-off-by: David Nind <david@davidnind.com> Created attachment 174056 [details] [review] Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 174057 [details] [review] Bug 37910: Minor improvements to comment form Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 174058 [details] [review] Bug 37910: Sync fixes to detail page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> I have a small conflict here I am not sure about - can you please rebase? (In reply to Katrin Fischer from comment #19) > I have a small conflict here I am not sure about - can you please rebase? I think this might have slipped through. As this is a bug fix, I don't need to extend deadlines now, but would prefer to have it before Wednesday. Not for 24.11.00. Created attachment 174703 [details] [review] Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 174704 [details] [review] Bug 37910: Minor improvements to comment form Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 174705 [details] [review] Bug 37910: Sync fixes to detail page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Just a rebase Pushed for 24.11! Well done everyone, thank you! |