Bug 37910 - Minor spacing issues in the catalog concerns page
Summary: Minor spacing issues in the catalog concerns page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Aleisha Amohia
URL:
Keywords: regression
Depends on: 35402
Blocks: 37912
  Show dependency treegraph
 
Reported: 2024-09-12 18:42 UTC by Caroline Cyr La Rose
Modified: 2024-11-20 17:51 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37910: Update concerns styling to flexbox (11.46 KB, patch)
2024-10-29 14:06 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
24.05 Modal (deleted)
2024-10-29 14:09 UTC, Martin Renvoize (ashimema)
Details
Modal using flex (113.81 KB, image/png)
2024-10-29 14:10 UTC, Martin Renvoize (ashimema)
Details
24.05 Modal (before bootstrap 5) (116.23 KB, image/png)
2024-10-29 14:10 UTC, Martin Renvoize (ashimema)
Details
Bug 37910: Minor improvements to comment form (2.49 KB, patch)
2024-10-29 14:43 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37910: Sync fixes to detail page (4.21 KB, patch)
2024-10-29 15:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37910: Sync fixes to detail page (6.93 KB, patch)
2024-10-29 15:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37910: Update concerns styling to flexbox (11.39 KB, patch)
2024-10-29 22:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 37910: Minor improvements to comment form (2.54 KB, patch)
2024-10-29 22:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 37910: Sync fixes to detail page (6.82 KB, patch)
2024-10-29 22:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 37910: Update concerns styling to flexbox (11.45 KB, patch)
2024-11-06 03:07 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 37910: Minor improvements to comment form (2.59 KB, patch)
2024-11-06 03:07 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 37910: Sync fixes to detail page (6.88 KB, patch)
2024-11-06 03:07 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 37910: Update concerns styling to flexbox (11.62 KB, patch)
2024-11-18 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37910: Minor improvements to comment form (2.66 KB, patch)
2024-11-18 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37910: Sync fixes to detail page (7.10 KB, patch)
2024-11-18 14:39 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-09-12 18:42:44 UTC
There are some spaces missing in the catalog concerns table.

To get there:
1. Enable the CatalogConcerns system preference
2. Search for a bibliographic record and access its details page
3. Click New > New catalog concern
4. Enter a title (an optionally a description)
5. Click Submit
6. Click the Concerns tab
7. Click the Details button next to the concern
8. Write an update
9. Search for and choose a patron in the Change assignee field
10. Click Update
   --> In the table in the record details page, there is no space between the status (Open) and the Assigned to string
11. Go to Cataloging > Catalog concerns
   --> Same problem as above
   --> There is also no space between the title of the ticket and the speech bubble indicating there has been an update (this is ok in the record details page)
Comment 1 Caroline Cyr La Rose 2024-09-12 18:51:46 UTC
I also noticed there are spaces missing when viewing the updated ticket.

- Between the assignee's name and the description (I feel like those two things should not be on the same line?)
- Between the "Private" and the text of the update
- Between the date of the update and the assignee
Comment 2 Caroline Cyr La Rose 2024-09-12 20:20:27 UTC
I found another one. If you resolve the concern, and show the resolved concerns in  the table, there is no space between the name/link of the staff and the date.
Comment 3 Martin Renvoize (ashimema) 2024-10-29 14:06:43 UTC
Created attachment 173650 [details] [review]
Bug 37910: Update concerns styling to flexbox

With the update to bootstrap 5 we loose some of the absolute and
relative positioning helpers, namely pull-right, which were used in the
catalog concerns pages.

This patch updates the table and modal styling to use modern flexbox
utlities from bootstrap 5 instead to improve the styling and fix the
regressions.
Comment 4 Martin Renvoize (ashimema) 2024-10-29 14:09:09 UTC
Created attachment 173651 [details]
24.05 Modal
Comment 5 Martin Renvoize (ashimema) 2024-10-29 14:09:33 UTC
The content of attachment 173651 [details] has been deleted
Comment 6 Martin Renvoize (ashimema) 2024-10-29 14:10:05 UTC
Created attachment 173652 [details]
Modal using flex
Comment 7 Martin Renvoize (ashimema) 2024-10-29 14:10:45 UTC
Created attachment 173653 [details]
24.05 Modal (before bootstrap 5)
Comment 8 Martin Renvoize (ashimema) 2024-10-29 14:43:25 UTC
Created attachment 173659 [details] [review]
Bug 37910: Minor improvements to comment form
Comment 9 Martin Renvoize (ashimema) 2024-10-29 15:00:28 UTC
Created attachment 173660 [details] [review]
Bug 37910: Sync fixes to detail page
Comment 10 Martin Renvoize (ashimema) 2024-10-29 15:20:03 UTC
Created attachment 173661 [details] [review]
Bug 37910: Sync fixes to detail page
Comment 11 David Nind 2024-10-29 22:29:46 UTC
This fixes all the issues Caroline identified.

However, there is one new thing that I noted:

1. On the details page for a record > Concerns > Details column:
   . Before the patch: the title and number of comments/updates are a link (I think it is just one link): clicking either of these opens the details view for the catalog concern (as expected)
   . After the patch: the details view doesn't open

2. On the catalog concerns listing (Cataloging > Catalog concerns):
   . Before the patch: the title and number of comments/updates are separate links - clicking on them doesn't open the details view
   . After the patch: same behavour as before the patch, no details view opens
Comment 12 David Nind 2024-10-29 22:36:56 UTC
(In reply to David Nind from comment #11)
> This fixes all the issues Caroline identified.
> 
> However, there is one new thing that I noted:
> 
> 1. On the details page for a record > Concerns > Details column:
>    . Before the patch: the title and number of comments/updates are a link
> (I think it is just one link): clicking either of these opens the details
> view for the catalog concern (as expected)
>    . After the patch: the details view doesn't open
> 
> 2. On the catalog concerns listing (Cataloging > Catalog concerns):
>    . Before the patch: the title and number of comments/updates are separate
> links - clicking on them doesn't open the details view
>    . After the patch: same behavour as before the patch, no details view
> opens

This is fixed by bug 37912.
Comment 13 David Nind 2024-10-29 22:39:14 UTC
Created attachment 173692 [details] [review]
Bug 37910: Update concerns styling to flexbox

With the update to bootstrap 5 we loose some of the absolute and
relative positioning helpers, namely pull-right, which were used in the
catalog concerns pages.

This patch updates the table and modal styling to use modern flexbox
utlities from bootstrap 5 instead to improve the styling and fix the
regressions.

Signed-off-by: David Nind <david@davidnind.com>
Comment 14 David Nind 2024-10-29 22:39:16 UTC
Created attachment 173693 [details] [review]
Bug 37910: Minor improvements to comment form

Signed-off-by: David Nind <david@davidnind.com>
Comment 15 David Nind 2024-10-29 22:39:19 UTC
Created attachment 173694 [details] [review]
Bug 37910: Sync fixes to detail page

Signed-off-by: David Nind <david@davidnind.com>
Comment 16 Aleisha Amohia 2024-11-06 03:07:08 UTC
Created attachment 174056 [details] [review]
Bug 37910: Update concerns styling to flexbox

With the update to bootstrap 5 we loose some of the absolute and
relative positioning helpers, namely pull-right, which were used in the
catalog concerns pages.

This patch updates the table and modal styling to use modern flexbox
utlities from bootstrap 5 instead to improve the styling and fix the
regressions.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 17 Aleisha Amohia 2024-11-06 03:07:11 UTC
Created attachment 174057 [details] [review]
Bug 37910: Minor improvements to comment form

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 18 Aleisha Amohia 2024-11-06 03:07:14 UTC
Created attachment 174058 [details] [review]
Bug 37910: Sync fixes to detail page

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 19 Katrin Fischer 2024-11-07 16:22:44 UTC
I have a small conflict here I am not sure about - can you please rebase?
Comment 20 Katrin Fischer 2024-11-11 17:01:32 UTC
(In reply to Katrin Fischer from comment #19)
> I have a small conflict here I am not sure about - can you please rebase?

I think this might have slipped through. As this is a bug fix, I don't need to extend deadlines now, but would prefer to have it before Wednesday.
Comment 21 Katrin Fischer 2024-11-14 14:34:57 UTC
Not for 24.11.00.
Comment 22 Martin Renvoize (ashimema) 2024-11-18 14:39:45 UTC
Created attachment 174703 [details] [review]
Bug 37910: Update concerns styling to flexbox

With the update to bootstrap 5 we loose some of the absolute and
relative positioning helpers, namely pull-right, which were used in the
catalog concerns pages.

This patch updates the table and modal styling to use modern flexbox
utlities from bootstrap 5 instead to improve the styling and fix the
regressions.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 23 Martin Renvoize (ashimema) 2024-11-18 14:39:48 UTC
Created attachment 174704 [details] [review]
Bug 37910: Minor improvements to comment form

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 24 Martin Renvoize (ashimema) 2024-11-18 14:39:50 UTC
Created attachment 174705 [details] [review]
Bug 37910: Sync fixes to detail page

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 25 Martin Renvoize (ashimema) 2024-11-18 14:40:05 UTC
Just a rebase
Comment 26 Katrin Fischer 2024-11-18 16:08:35 UTC
Pushed for 24.11!

Well done everyone, thank you!