Bug 37912 - Catalog concerns - Broken link under concern title
Summary: Catalog concerns - Broken link under concern title
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Aleisha Amohia
URL:
Keywords: regression
Depends on: 37910
Blocks: 34324
  Show dependency treegraph
 
Reported: 2024-09-12 20:42 UTC by Caroline Cyr La Rose
Modified: 2024-11-11 16:50 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37912: Restore detail-trigger handling (1.75 KB, patch)
2024-10-29 15:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37912: Restore detail-trigger handling (1.81 KB, patch)
2024-10-29 17:27 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 37912: Restore detail-trigger handling (1.81 KB, patch)
2024-10-29 17:27 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 37912: Restore detail-trigger handling (1.87 KB, patch)
2024-11-06 03:09 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-09-12 20:42:15 UTC
In the catalog concerns page, nothing happens when you click on the title of a concern.

To recreate:
1. Enable the CatalogConcerns system preference
2. In a bibliographic record, click New > New catalog concern 
3. Fill out the title (and optionally the description)
4. Click Submit
5. Go to Cataloging > Catalog concerns
6. Click on the title of the concern
   --> Nothing happens

According to the manual, it used to lead to the concern details modal.
Comment 1 Phil Ringnalda 2024-09-13 17:33:38 UTC
It still tries to, https://git.koha-community.org/Koha-community/Koha/src/commit/ea17ce2ffa1f2db88f85e86646513dde34d24eed/koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js#L3 thinks when you click on the link it will find and .click() the button at the end of the table row. It just doesn't find it.
Comment 2 Martin Renvoize (ashimema) 2024-10-29 15:20:50 UTC
Created attachment 173662 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.
Comment 3 Biblibre Sandboxes 2024-10-29 17:27:32 UTC
Created attachment 173684 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 4 Biblibre Sandboxes 2024-10-29 17:27:35 UTC
Created attachment 173685 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 5 Aleisha Amohia 2024-11-06 03:09:14 UTC
Created attachment 174059 [details] [review]
Bug 37912: Restore detail-trigger handling

This patch converts our jQuery based click to native JS and restores the
bootstrap modal button click trigger handling.

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 6 Katrin Fischer 2024-11-07 16:33:51 UTC
Pushed for 24.11!

Well done everyone, thank you!