Bug 38033

Summary:	Koha::Biblio->record does not return items
Product:	Koha	Reporter:	Janusz Kaczmarek <januszop>
Component:	Architecture, internals, and plumbing	Assignee:	Janusz Kaczmarek <januszop>
Status:	RESOLVED INVALID	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	dcook, pedro.amorim, tomascohen
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	Sponsored	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	33083
Bug Blocks:
Attachments:	Bug 38033: Koha::Biblio->record does not return items Bug 38033: Koha::Biblio->record does not return items

Description Janusz Kaczmarek 2024-09-30 11:52:26 UTC

Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward
alias for Koha::Biblio::Metadata->record but it does not pass the
parameters to $self->metadata->record call.  This may lead
to misunderstandings and possible bugs.

Comment 1 Janusz Kaczmarek 2024-09-30 11:58:06 UTC

Created attachment 172221 [details] [review]
Bug 38033: Koha::Biblio->record does not return items

Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward
alias for Koha::Biblio::Metadata->record but it does not pass the
parameters to $self->metadata->record call.  This may lead
to misunderstandings and possible bugs.

The provided patch corrects this issue.  Use unit test to test.

Sponsored-by: Ignatianum University in Cracow

Comment 2 Janusz Kaczmarek 2024-09-30 12:13:02 UTC

Use case:

one would expect $biblio->record({ embed_items => 1 }) returns the linked items (as it does $biblio->metadata->record({ embed_items => 1 }) ) -- but unfortunately now it does not.

Comment 3 Roman Dolny 2024-09-30 20:03:16 UTC

Created attachment 172237 [details] [review]
Bug 38033: Koha::Biblio->record does not return items

Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward
alias for Koha::Biblio::Metadata->record but it does not pass the
parameters to $self->metadata->record call.  This may lead
to misunderstandings and possible bugs.

The provided patch corrects this issue.  Use unit test to test.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Comment 4 David Cook 2024-10-21 03:58:43 UTC

This is an interesting one. Probably should have a different title, but looking at the code... it seems pretty reasonable.

Comment 5 Tomás Cohen Arazi (tcohen) 2024-10-29 10:53:41 UTC

We are headed toward bug 31224 instead of this.

Comment 6 Pedro Amorim 2024-10-29 14:45:56 UTC

(In reply to Tomás Cohen Arazi (tcohen) from comment #5)
> We are headed toward bug 31224 instead of this.

Setting as RESOLVED INVALID.