Bug 33083 - Handle generic collection of records methods
Summary: Handle generic collection of records methods
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Agustín Moyano
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks: 31224 32734 32735 38033
  Show dependency tree / graph
 
Reported: 2023-02-27 22:09 UTC by Agustín Moyano
Modified: 2024-09-30 11:52 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00, 22.11.04
Circulation function:

Attachments
Bug 33083: Add a generic class to handle methods for collections of records (5.73 KB, patch)
2023-02-27 22:18 UTC, Agustín Moyano 		Details | Diff | Splinter Review
Bug 33083: Add a generic class to handle methods for collections of records (7.15 KB, patch)
2023-02-28 14:34 UTC, Agustín Moyano 		Details | Diff | Splinter Review
Bug 33083: Add a generic class to handle methods for collections of records (7.21 KB, patch)
2023-03-10 14:30 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33083: Add a generic class to handle methods for collections of records (7.27 KB, patch)
2023-03-13 17:52 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agustín Moyano 2023-02-27 22:09:05 UTC 
Add a generic way to handle methods for collections of records
Comment 1 Agustín Moyano 2023-02-27 22:18:15 UTC 
Created attachment 147473 [details] [review]
Bug 33083: Add a generic class to handle methods for collections of records

To test:
1. Apply patch
2. prove t/db_dependent/Koha/Objects/Record/Collections.t
Comment 2 Agustín Moyano 2023-02-28 14:34:00 UTC 
Created attachment 147491 [details] [review]
Bug 33083: Add a generic class to handle methods for collections of records

To test:
1. Apply patch
2. prove t/db_dependent/Koha/Objects/Record/Collections.t
Comment 3 Kyle M Hall (khall) 2023-03-10 14:30:56 UTC 
Created attachment 148074 [details] [review]
Bug 33083: Add a generic class to handle methods for collections of records

To test:
1. Apply patch
2. prove t/db_dependent/Koha/Objects/Record/Collections.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-03-13 17:52:31 UTC 
Created attachment 148135 [details] [review]
Bug 33083: Add a generic class to handle methods for collections of records

To test:
1. Apply patch
2. prove t/db_dependent/Koha/Objects/Record/Collections.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-03-13 18:13:46 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-14 10:18:17 UTC 
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 7 Martin Renvoize (ashimema) 2023-03-21 09:33:36 UTC 
This is also needed for bug 32734 which was backported.
Comment 8 Martin Renvoize (ashimema) 2023-03-21 09:35:20 UTC 
Pushed to 22.11.x for 22.11.04
Comment 9 Caroline Cyr La Rose 2023-05-12 13:19:02 UTC 
This seems like only backend stuff, nothing to document. Closing, but feel free to  reopen with more details if I'm wrong.