Bug 38033 - Koha::Biblio->record does not return items
Summary: Koha::Biblio->record does not return items
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Janusz Kaczmarek
QA Contact: Testopia
URL:
Keywords:
Depends on: 33083
Blocks:
  Show dependency treegraph
 
Reported: 2024-09-30 11:52 UTC by Janusz Kaczmarek
Modified: 2024-09-30 20:03 UTC (History)
0 users

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38033: Koha::Biblio->record does not return items (5.26 KB, patch)
2024-09-30 11:58 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 38033: Koha::Biblio->record does not return items (5.31 KB, patch)
2024-09-30 20:03 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-09-30 11:52:26 UTC
Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward
alias for Koha::Biblio::Metadata->record but it does not pass the
parameters to $self->metadata->record call.  This may lead
to misunderstandings and possible bugs.
Comment 1 Janusz Kaczmarek 2024-09-30 11:58:06 UTC
Created attachment 172221 [details] [review]
Bug 38033: Koha::Biblio->record does not return items

Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward
alias for Koha::Biblio::Metadata->record but it does not pass the
parameters to $self->metadata->record call.  This may lead
to misunderstandings and possible bugs.

The provided patch corrects this issue.  Use unit test to test.

Sponsored-by: Ignatianum University in Cracow
Comment 2 Janusz Kaczmarek 2024-09-30 12:13:02 UTC
Use case:

one would expect $biblio->record({ embed_items => 1 }) returns the linked items (as it does $biblio->metadata->record({ embed_items => 1 }) ) -- but unfortunately now it does not.
Comment 3 Roman Dolny 2024-09-30 20:03:16 UTC
Created attachment 172237 [details] [review]
Bug 38033: Koha::Biblio->record does not return items

Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward
alias for Koha::Biblio::Metadata->record but it does not pass the
parameters to $self->metadata->record call.  This may lead
to misunderstandings and possible bugs.

The provided patch corrects this issue.  Use unit test to test.

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>