Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward alias for Koha::Biblio::Metadata->record but it does not pass the parameters to $self->metadata->record call. This may lead to misunderstandings and possible bugs.
Created attachment 172221 [details] [review] Bug 38033: Koha::Biblio->record does not return items Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward alias for Koha::Biblio::Metadata->record but it does not pass the parameters to $self->metadata->record call. This may lead to misunderstandings and possible bugs. The provided patch corrects this issue. Use unit test to test. Sponsored-by: Ignatianum University in Cracow
Use case: one would expect $biblio->record({ embed_items => 1 }) returns the linked items (as it does $biblio->metadata->record({ embed_items => 1 }) ) -- but unfortunately now it does not.
Created attachment 172237 [details] [review] Bug 38033: Koha::Biblio->record does not return items Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward alias for Koha::Biblio::Metadata->record but it does not pass the parameters to $self->metadata->record call. This may lead to misunderstandings and possible bugs. The provided patch corrects this issue. Use unit test to test. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>