Bug 38061

Created attachment 172297 [details] [review]
Bug 38061: Add item column to serial collections table

This patch adds a column to the table to link to the item

Test plan:
1) Add a new subscription to a serial record (with the option 'create an item record' selected)
2) Receive several issues and create the linked items
3) Navigate to the serials collection table
4) There should be a column for the linked item
5) Click on one of the links, it should display the item

Created attachment 172298 [details] [review]
Bug 38061: Tidy serials-collection.pl

Created attachment 172299 [details] [review]
Bug 38061: Remove pre-selection of serials in the table

Test plan:
1) Navigate to the serials-collection table
2) None of the checkboxes in the left hand column should be selected

Sponsored-by: Association KohaLa - https://koha-fr.org/

Please improve bug description to be more specific :)

Katrin, when you're in serials-collection table, some issues are pre-ticked : expected issues, overdue issues... So, if you wish to delete issues, you must first uncheck those already ticked. We would like no issues to be pre-ticked to avoid deletion errors.

I think removing the pre-selection would be an unwanted workflow change for some libraries. We train that these are the issues predicted but not received yet.

It currently poses a problem for batch deletions of issues. Issues may be deleted if you forget to untick the box.

But it adds clicks for other workflows. 
Would a select all/unselect all or some other GUI option do the trick instead?

It's certainly a change that I would not hide in a "seemingly" unrelated bug, but something we should discuss with libraries using that module.

I understand. It's a request from users in the French community.
I've asked the people who took part in the working group to come and discuss the ticket.

I hope that didn't come across as unfriendly, I am just trying to be careful concerning side effects when behavior is changed. I feel a lot of libraries will be very happy about the enhancements for serials KohaLa/PTFS-E are working on.

I think I got curious about the bug because of the bug description - "Improvements" or "enhancements" usually is a trigger for questions ;)

Ideally this might have been better as 2 small bugs:

* Adding the new column for the item link
* Changing the checkboxes

I have taken another look at the serials collections page and I think maybe the "Receive" link in the toolbar already does something very similar, but with a different selection of status (EXPECTED, LATE vs. EXPECTED, LATE, MISSING_STATUSES, CLAIMED)

Maybe the receive link would be enough and it would be OK to remove the pre-selection. Adding some others for opinions.

No, don't worry :) 
In addition to the ‘receive’ link, you can sort the columns. 
In this case, I really think that pre-ticking the boxes is unnecessary.
Let's wait for feedback from other users ;)

I think the two workflows can coexist! Let the user choose to switch between having the checkbox checked by default or unchecked by default, with a unchecked checkbox in the subscription. ;)

I tested this by adding a subscription to a record. I received several issues. I can see the link column but the column is blank. I'm not sure I understand what generates the link? I can see the received issues on the holding table in the Bibliographic view, so I would expect a link to the Item Detail view for the issue from the serial collection page?

Esther, You need to create an item when you receive the issue to see the link.

Created attachment 172792 [details]
Missing issue on serials collection page.

I'm not sure why it did not work initially because I did configure the subscription to create the item records (probably a problem with the sandbox). On my second attempt, it did appear to work and I can see the links to the item records in the Link column. However, I received 3 issues and the first issue is not appearing on the serials collection page. The next 2 issues are with their links. (Image example attached).