Bug 38061 - Serials collection table improvements
Summary: Serials collection table improvements
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-02 11:24 UTC by Matt Blenkinsop
Modified: 2025-05-19 14:10 UTC (History)
11 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38061: Add item column to serial collections table (4.57 KB, patch)
2024-10-02 11:32 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38061: Tidy serials-collection.pl (17.82 KB, patch)
2024-10-02 11:32 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38061: Remove pre-selection of serials in the table (1.08 KB, patch)
2024-10-02 11:32 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Missing issue on serials collection page. (84.38 KB, image/jpeg)
2024-10-15 18:13 UTC, Esther Melander
Details
Bug 38061: Add item column to serial collections table (4.60 KB, patch)
2025-01-13 13:37 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38061: Tidy serials-collection.pl (17.86 KB, patch)
2025-01-13 13:37 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38061: Remove pre-selection of serials in the table (1.12 KB, patch)
2025-01-13 13:37 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38061: Add item column to serial collections table (4.58 KB, patch)
2025-03-24 15:31 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38061: Remove pre-selection of serials in the table (1.13 KB, patch)
2025-03-24 15:31 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected (29.07 KB, patch)
2025-05-09 08:45 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-10-02 11:24:04 UTC

    
Comment 1 Matt Blenkinsop 2024-10-02 11:32:40 UTC
Created attachment 172297 [details] [review]
Bug 38061: Add item column to serial collections table

This patch adds a column to the table to link to the item

Test plan:
1) Add a new subscription to a serial record (with the option 'create an item record' selected)
2) Receive several issues and create the linked items
3) Navigate to the serials collection table
4) There should be a column for the linked item
5) Click on one of the links, it should display the item
Comment 2 Matt Blenkinsop 2024-10-02 11:32:42 UTC
Created attachment 172298 [details] [review]
Bug 38061: Tidy serials-collection.pl
Comment 3 Matt Blenkinsop 2024-10-02 11:32:44 UTC
Created attachment 172299 [details] [review]
Bug 38061: Remove pre-selection of serials in the table

Test plan:
1) Navigate to the serials-collection table
2) None of the checkboxes in the left hand column should be selected

Sponsored-by: Association KohaLa - https://koha-fr.org/
Comment 4 Katrin Fischer 2024-10-02 13:53:20 UTC
Please improve bug description to be more specific :)
Comment 5 Nathalie SAVARIT 2024-10-09 08:27:13 UTC
Katrin, when you're in serials-collection table, some issues are pre-ticked : expected issues, overdue issues... So, if you wish to delete issues, you must first uncheck those already ticked. We would like no issues to be pre-ticked to avoid deletion errors.
Comment 6 Katrin Fischer 2024-10-09 09:29:04 UTC
I think removing the pre-selection would be an unwanted workflow change for some libraries. We train that these are the issues predicted but not received yet.
Comment 7 Nathalie SAVARIT 2024-10-09 10:37:28 UTC
It currently poses a problem for batch deletions of issues. Issues may be deleted if you forget to untick the box.
Comment 8 Katrin Fischer 2024-10-09 11:44:12 UTC
But it adds clicks for other workflows. 
Would a select all/unselect all or some other GUI option do the trick instead?

It's certainly a change that I would not hide in a "seemingly" unrelated bug, but something we should discuss with libraries using that module.
Comment 9 Nathalie SAVARIT 2024-10-10 09:33:47 UTC
I understand. It's a request from users in the French community.
I've asked the people who took part in the working group to come and discuss the ticket.
Comment 10 Katrin Fischer 2024-10-10 10:37:05 UTC
I hope that didn't come across as unfriendly, I am just trying to be careful concerning side effects when behavior is changed. I feel a lot of libraries will be very happy about the enhancements for serials KohaLa/PTFS-E are working on.

I think I got curious about the bug because of the bug description - "Improvements" or "enhancements" usually is a trigger for questions ;)

Ideally this might have been better as 2 small bugs:

* Adding the new column for the item link
* Changing the checkboxes

I have taken another look at the serials collections page and I think maybe the "Receive" link in the toolbar already does something very similar, but with a different selection of status (EXPECTED, LATE vs. EXPECTED, LATE, MISSING_STATUSES, CLAIMED)

Maybe the receive link would be enough and it would be OK to remove the pre-selection. Adding some others for opinions.
Comment 11 Nathalie SAVARIT 2024-10-10 12:40:22 UTC
No, don't worry :) 
In addition to the ‘receive’ link, you can sort the columns. 
In this case, I really think that pre-ticking the boxes is unnecessary.
Let's wait for feedback from other users ;)
Comment 12 Martin AUBEUT 2024-10-11 15:03:40 UTC
I think the two workflows can coexist! Let the user choose to switch between having the checkbox checked by default or unchecked by default, with a unchecked checkbox in the subscription. ;)
Comment 13 Esther Melander 2024-10-11 19:05:17 UTC
I tested this by adding a subscription to a record. I received several issues. I can see the link column but the column is blank. I'm not sure I understand what generates the link? I can see the received issues on the holding table in the Bibliographic view, so I would expect a link to the Item Detail view for the issue from the serial collection page?
Comment 14 Nathalie SAVARIT 2024-10-14 06:04:44 UTC
Esther, You need to create an item when you receive the issue to see the link.
Comment 15 Esther Melander 2024-10-15 18:13:22 UTC
Created attachment 172792 [details]
Missing issue on serials collection page.

I'm not sure why it did not work initially because I did configure the subscription to create the item records (probably a problem with the sandbox). On my second attempt, it did appear to work and I can see the links to the item records in the Link column. However, I received 3 issues and the first issue is not appearing on the serials collection page. The next 2 issues are with their links. (Image example attached).
Comment 16 Nathalie SAVARIT 2025-01-07 08:03:33 UTC
Hi Ester. The issues are classified by year of publication (not by date received). 
The first issue must be on the ‘2024’ tab (publication 10/01/2024), which is why it does not appear with the others.
Comment 17 Biblibre Sandboxes 2025-01-13 13:37:14 UTC
Created attachment 176440 [details] [review]
Bug 38061: Add item column to serial collections table

This patch adds a column to the table to link to the item

Test plan:
1) Add a new subscription to a serial record (with the option 'create an item record' selected)
2) Receive several issues and create the linked items
3) Navigate to the serials collection table
4) There should be a column for the linked item
5) Click on one of the links, it should display the item

Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 18 Biblibre Sandboxes 2025-01-13 13:37:17 UTC
Created attachment 176441 [details] [review]
Bug 38061: Tidy serials-collection.pl

Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 19 Biblibre Sandboxes 2025-01-13 13:37:19 UTC
Created attachment 176442 [details] [review]
Bug 38061: Remove pre-selection of serials in the table

Test plan:
1) Navigate to the serials-collection table
2) None of the checkboxes in the left hand column should be selected

Sponsored-by: Association KohaLa - https://koha-fr.org/
Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 20 Nathalie SAVARIT 2025-01-13 13:39:47 UTC
Tested on Hackathon KohaLa Lyon, 13th january 2025.
Feel free to give more details if you still have issues when testing.
Comment 21 Sophie Wawrzyniak 2025-01-14 10:27:05 UTC
(In reply to Biblibre Sandboxes from comment #17)
> Created attachment 176440 [details] [review] [review]
> Bug 38061: Add item column to serial collections table
> 
> This patch adds a column to the table to link to the item
> 
> Test plan:
> 1) Add a new subscription to a serial record (with the option 'create an
> item record' selected)
> 2) Receive several issues and create the linked items
> 3) Navigate to the serials collection table
> 4) There should be a column for the linked item
> 5) Click on one of the links, it should display the item
> 
> Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>

Can the 'linked item' column be editable ? (for example if the item is created retrospectively).
Idea from hackathon KohaLa 2025.
Comment 22 Jonathan Druart 2025-01-28 15:34:04 UTC
Comment on attachment 176441 [details] [review]
Bug 38061: Tidy serials-collection.pl

We no longer want tidy patches.
Comment 23 Nathalie SAVARIT 2025-03-21 13:41:04 UTC
Hi,
what about Martin's proposition : "I think the two workflows can coexist! Let the user choose to switch between having the checkbox checked by default or unchecked by default, with a unchecked checkbox in the subscription. ;)"
This was the most popular option at the Koha symposium working group this week.
Comment 24 Nathalie SAVARIT 2025-03-21 13:47:14 UTC
And keep on current operation: if nothing is ticked, no issues can be received.
Comment 25 Matt Blenkinsop 2025-03-24 15:31:26 UTC
Created attachment 179644 [details] [review]
Bug 38061: Add item column to serial collections table

This patch adds a column to the table to link to the item

Test plan:
1) Add a new subscription to a serial record (with the option 'create an item record' selected)
2) Receive several issues and create the linked items
3) Navigate to the serials collection table
4) There should be a column for the linked item
5) Click on one of the links, it should display the item

Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 26 Matt Blenkinsop 2025-03-24 15:31:29 UTC
Created attachment 179645 [details] [review]
Bug 38061: Remove pre-selection of serials in the table

Test plan:
1) Navigate to the serials-collection table
2) None of the checkboxes in the left hand column should be selected

Sponsored-by: Association KohaLa - https://koha-fr.org/
Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 27 Lucas Gass (lukeg) 2025-05-08 15:48:44 UTC
This looks good and is working well in my testing. I am a bit hesitant to pass QA as there seems to be some disagreement about the initial state of check boxes? This is a change in behavior.
Comment 28 Matt Blenkinsop 2025-05-09 08:45:22 UTC
Created attachment 182159 [details] [review]
Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected

Test plan:
Apply the patches and update the database
1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked
2) Receive some items against the subscription
3) Navigate to the collections table
4) The checkboxes should be pre-selected as per previous behaviour in Koha
5) Edit the subscription and uncheck the checkbox
6) Return to the collections table and the checkboxes should all be unchecked
Comment 29 Matt Blenkinsop 2025-05-09 08:47:04 UTC
I've added a concept patch for Martin's suggestion. It adds a column to the subscription table to set whether the collections table should be pre-selected or not. Let me know if this meets the expected behaviour :)
Comment 30 Nathalie SAVARIT 2025-05-09 13:28:08 UTC
Hi Matthew,
thanks for adding a concept patch for Martin's suggestion ! 
This is what the French community has been waiting for. That's fine for me.
So there is no longer any ambiguity or disagreement about the initial state of check boxes.