Bug 38085

Summary: Untranslatable options in OPACAuthorIdentifiersAndInformation
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: I18N/L10NAssignee: Jonathan Druart <jonathan.druart>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: f.demians, fridolin.somers, jonathan.druart, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Bug Depends on: 29948    
Bug Blocks:    
Attachments: Bug 38085: Pick multiple_sortable options for translation
Bug 38085: Pick multiple_sortable options for translation
Bug 38085: Pick multiple_sortable options for translation

Description Caroline Cyr La Rose 2024-10-03 21:04:30 UTC
When I translated the strings for OPACAuthorIdentifiersAndInformation in Weblate, the options for the system preference are not there. I also searched for "Activity", but there is no string "Activity (372$a$s$t)".
Comment 1 Jonathan Druart 2024-10-07 09:34:48 UTC
Created attachment 172448 [details] [review]
Bug 38085: Pick multiple_sortable options for translation

Bug 29948 added a "multiple_sortable" type for sysprefs, to have the
options sortable. But the options were not picked for translation.

This patch fixes it.

Test plan:
Run `cd misc/translator && perl translate update LANG` before and after
this patch. Notice that with this patch you see the different options of
OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg.
"Associated group (373$a$s$t$u$v$0)")
Translate the options
Install the translated version of the templates and confirm that the
strings appear translated on the interface.
Comment 2 Caroline Cyr La Rose 2024-10-07 14:24:32 UTC
Created attachment 172472 [details] [review]
Bug 38085: Pick multiple_sortable options for translation

Bug 29948 added a "multiple_sortable" type for sysprefs, to have the
options sortable. But the options were not picked for translation.

This patch fixes it.

Test plan:
Run `cd misc/translator && perl translate update LANG` before and after
this patch. Notice that with this patch you see the different options of
OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg.
"Associated group (373$a$s$t$u$v$0)")
Translate the options
Install the translated version of the templates and confirm that the
strings appear translated on the interface.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2024-10-07 14:24:48 UTC
Thanks Jonathan!
Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-25 14:25:08 UTC
Created attachment 173371 [details] [review]
Bug 38085: Pick multiple_sortable options for translation

Bug 29948 added a "multiple_sortable" type for sysprefs, to have the
options sortable. But the options were not picked for translation.

This patch fixes it.

Test plan:
Run `cd misc/translator && perl translate update LANG` before and after
this patch. Notice that with this patch you see the different options of
OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg.
"Associated group (373$a$s$t$u$v$0)")
Translate the options
Install the translated version of the templates and confirm that the
strings appear translated on the interface.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Katrin Fischer 2024-10-25 14:42:26 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-20 23:32:13 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-13 15:13:32 UTC
Depends on Bug 29948 not in 23.11.x