Bug 29948 - Display author information for researchers
Summary: Display author information for researchers
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 29897
Blocks:
  Show dependency treegraph
 
Reported: 2022-01-26 08:23 UTC by Jonathan Druart
Modified: 2024-05-29 12:20 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement enables the display of authority record information about authors and contributors on OPAC record and authority detail pages.[1] Use the new system preference OPACAuthorIdentifiersAndInformation to configure what information to display, and in what order. (This replaces OPACAuthorIdentifiers, which enabled the display of identifiers from 024$a and 024$2.) Information available for display: - Field of activity (372$a$s$t) - Address (371$a$b$d$e) - Associated group (373$a$s$t$u$v$0) - Electronic mail address (371$m) - Identifiers (024$2$a)[2] - Occupation (374$a$s$t$u$v$0) - Place of birth (370$a) - Place of death (370$b) - URI (371$u) [1] Displayed on the bibliographic record detail page in the holdings section under a new 'Author information' tab; and on the authority record detail page under the 'Author information' heading. [2] Valid codes for author and contributor identifiers to use in the source subfield (024$2) are currently: orcid (ORCID), scopus (ScopusID), loop (Loop ID), rid (Publons ID), and viaf (VIAF ID).
Version(s) released in:
24.05.00


Attachments
Bug 29948: Display authors information along with the identifiers (15.91 KB, patch)
2024-03-15 08:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.00 KB, patch)
2024-03-15 08:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.57 KB, patch)
2024-03-15 08:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.39 KB, patch)
2024-03-22 11:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Display authors information along with the identifiers (15.91 KB, patch)
2024-03-22 11:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.00 KB, patch)
2024-03-22 11:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.57 KB, patch)
2024-03-22 11:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.39 KB, patch)
2024-03-22 11:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Display authors information along with the identifiers (15.91 KB, patch)
2024-05-05 19:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.00 KB, patch)
2024-05-05 19:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.57 KB, patch)
2024-05-05 19:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.39 KB, patch)
2024-05-05 19:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: (follow-up) Update system preference description and heading (5.59 KB, patch)
2024-05-06 06:56 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: Display authors information along with the identifiers (15.93 KB, patch)
2024-05-06 07:53 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.01 KB, patch)
2024-05-06 07:53 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.60 KB, patch)
2024-05-06 07:53 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.42 KB, patch)
2024-05-06 07:53 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 29948: Display authors information along with the identifiers (15.97 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.05 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.63 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.45 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: (follow-up) Update system preference description and heading (5.60 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Hide entry if empty (7.16 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Remove margin bottom for paragraph (2.81 KB, patch)
2024-05-06 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29948: Display authors information along with the identifiers (16.00 KB, patch)
2024-05-06 11:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.08 KB, patch)
2024-05-06 11:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.66 KB, patch)
2024-05-06 11:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.49 KB, patch)
2024-05-06 11:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: (follow-up) Update system preference description and heading (5.59 KB, patch)
2024-05-06 11:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: Hide entry if empty (7.21 KB, patch)
2024-05-06 11:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: Remove margin bottom for paragraph (2.85 KB, patch)
2024-05-06 11:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 29948: Display authors information along with the identifiers (16.07 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: OPACAuthorIdentifiersAndInformation (20.15 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: Allow to sort info (6.73 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: Fix display of selected values (1.55 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: (follow-up) Update system preference description and heading (5.65 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: Hide entry if empty (7.26 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: Remove margin bottom for paragraph (2.91 KB, patch)
2024-05-10 18:28 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 29948: Adjust sysprefs.sql (2.78 KB, patch)
2024-05-13 14:00 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-01-26 08:23:01 UTC
Display author's information from 371, 372, 373 (email, activity, etc.) in the same area than identifiers (from bug 29897).
Comment 1 Jonathan Druart 2024-03-15 08:04:28 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2024-03-15 08:05:41 UTC
Created attachment 163167 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital
Comment 3 Jonathan Druart 2024-03-15 08:05:44 UTC
Created attachment 163168 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital
Comment 4 Jonathan Druart 2024-03-15 08:05:47 UTC
Created attachment 163169 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital
Comment 5 Jonathan Druart 2024-03-15 08:06:01 UTC
Patches for discussion.

Are there all the info we need? How do you feel with how the info are displayed? Can we improve the display or everything is great like that?
Comment 6 Owen Leonard 2024-03-22 11:24:30 UTC
In my tests the re-ordering of options in system preferences is not being saved. I can enable or disable, but the order reverts after saving.

I'm not sure what I'm looking for on the OPAC authority detail page, but it doesn't look like I'm seeing the new information, even after restarting and reindexing.
Comment 7 Jonathan Druart 2024-03-22 11:47:38 UTC
Created attachment 163696 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly
Comment 8 Jonathan Druart 2024-03-22 11:50:52 UTC
(In reply to Owen Leonard from comment #6)
> In my tests the re-ordering of options in system preferences is not being
> saved. I can enable or disable, but the order reverts after saving.

Good catch, thanks. They were inserted correctly but the display was wrong.

> I'm not sure what I'm looking for on the OPAC authority detail page, but it
> doesn't look like I'm seeing the new information, even after restarting and
> reindexing.

You need data in the subfields you selected in the pref.
For instance select "Place of birth" in the pref, edit an authority record and set 370$a to somewhere. At the OPAC, bibliographic detail page of the record linked with this authority, you will notice a new tab "Author identifiers/information" which contains the place of birth next to the authority name.
Comment 9 Jonathan Druart 2024-03-22 11:52:21 UTC
Created attachment 163697 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital
Comment 10 Jonathan Druart 2024-03-22 11:52:24 UTC
Created attachment 163698 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital
Comment 11 Jonathan Druart 2024-03-22 11:52:26 UTC
Created attachment 163699 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital
Comment 12 Jonathan Druart 2024-03-22 11:52:29 UTC
Created attachment 163700 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly
Comment 13 Jonathan Druart 2024-05-05 19:02:32 UTC
Created attachment 166166 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital
Comment 14 Jonathan Druart 2024-05-05 19:02:35 UTC
Created attachment 166167 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital
Comment 15 Jonathan Druart 2024-05-05 19:02:38 UTC
Created attachment 166168 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital
Comment 16 Jonathan Druart 2024-05-05 19:02:41 UTC
Created attachment 166169 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly
Comment 17 David Nind 2024-05-06 06:56:07 UTC
Created attachment 166181 [details] [review]
Bug 29948: (follow-up) Update system preference description and heading

This follow-up:
1. Updates the OPACAuthorIdentifiersAndInformation system preference
   description.
2. Changes the OPAC heading used on the bibliographic record and
   authority record detail pages from "Author identifiers/information"
   to "Author information". Identfiers are a subset of author information
   and having just "Author information" is sufficient. In addition,
   the authority record doesn't have to include identifiers.

Signed-off-by: David Nind <david@davidnind.com>
Comment 18 David Nind 2024-05-06 07:05:56 UTC
I identified these two issues (wasn't sure how to fix these):

1. If there are no values in the authority record for these subfields, and they are selected in OPACAuthorIdentifiersAndInformation, they display the title without a value:
   - URI 371$u (when no value displays as: URI:)
   - Electronic email address 371$m (when no value displays as: Email address:)
2. Display of occupation information (374$a$s$t$u$v$0): there are extra lines between URI, Source of information, and Authority record control number or standard number. An HTML paragraph tag is used for each line, not sure if using another unordered list would work to display the information more cleanly.

I added a follow-up to:
1. Update the system preference description.[1]
2. Change the heading "Author identifiers/information" to "Author information". Rational: Identifiers are a type of author information, so just having "Author information" is sufficient. The authority record doesn't have to include identifiers now.

One other thing I noted:
- The Publons ID now redirects to the Web of Science website and the Web of Science ResearcherID. However, the Publons ID is not the same number as the Web of Science ResearcherID. So we can't just change the URL and name. Happy to create a new bug to add the Web of Science ResearcherID as a new identifier.

[1] System preference description
=================================

Current
-------

Display the following information for authors and contributors to the detail pages in the OPAC.

[names, tag, subfield]

Indentifiers: identifiers for authors and contributors to the detail pages in the OPAC. This feature requires authorities with 024$2 and 024$a. Valid source codes in $2 are currently: orcid, scopus, loop, rid and viaf.

Suggested
---------

Display this information about authors and contributors on OPAC detail pages:

[names, tag, subfield]

NOTE: Identifiers for authors and contributors - valid codes to use in the source subfield (024$2) are currently: orcid (ORCID), scopus (ScopusID), loop (Loop ID), rid (Publons ID), and viaf (VIAF ID).

Testing notes (using KTD)
=========================

1. Apply the patches, update the database (updatedatabase), and restart_all
2. Select all the options for the OPACAuthorIdentifiersAndInformation system preference.
3. Find a record with an author and a contributor (I used Programming Perl, biblionumber = 262)
4. For the main author, add some identifiers and additional information. I added this information to Foy, Brian D. (authority id = 148):
   . 024$a 90607948
   . 024$2 viaf
   -----
   . 370$a Place of birth
   . 370$b Place of death
   -----
   . 371$a My address
   . 371$b My City
   . 371$d My Country
   . 371$e 9400
   . 371$m me@example.com
   . 371$u https://example.com
   -----
   . 372$a Computer Science
   . 372$s 1987
   . 372$t 2038
   ----
   . 373$0 3333
   . 374$a MIT
   . 374$s 1988
   . 374$t 2020
   . 374$u https://www.mit.edu/
   . 374$v Academic profile
   ----
   . 374$0 911
   . 374$a Computer programmer
   . 374$s 1988
   . 374$t 2020
   . 374$u https://example.com
   . 374$v Wikipedia
   ----
   . 374$0 912
   . 374$a Historian
   . 374$s 2021
   . 374$t 2024
   . 374$u https://en.wikipedia.org/wiki/Perl
   . 374$v Wikipedia
5. Add some information to the authority record for a contributor (I added similar information from step 2 to Tom Christiansen, authid = 482).
6. View the author information on the OPAC record and authority details pages:
   . On the record details page, the information is shown under the 'Author information' tab
   . On the authority details page, the information is shown on the right-hand side
   ==> Result: The information should display correctly and in the order set in OPACAuthorIdentifiersAndInformation.
7. Rearrange the order of the information in OPACAuthorIdentifiersAndInformation, and refresh the OPAC record and authority detail pages:
   ==> Result: The order of the information on the pages should reflect the changes made.
8. Unselect some of the information shown in OPACAuthorIdentifiersAndInformation, and refresh the OPAC record and authority details pages:
   ==> Result: The information on the pages should reflect the changes made.
Comment 19 ByWater Sandboxes 2024-05-06 07:53:40 UTC
Created attachment 166183 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital
Signed-off-by: hugo <hagud@orex.es>
Comment 20 ByWater Sandboxes 2024-05-06 07:53:42 UTC
Created attachment 166184 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital
Signed-off-by: hugo <hagud@orex.es>
Comment 21 ByWater Sandboxes 2024-05-06 07:53:44 UTC
Created attachment 166185 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital
Signed-off-by: hugo <hagud@orex.es>
Comment 22 ByWater Sandboxes 2024-05-06 07:53:46 UTC
Created attachment 166186 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly

Signed-off-by: hugo <hagud@orex.es>
Comment 23 Jonathan Druart 2024-05-06 10:30:03 UTC
Created attachment 166197 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Comment 24 Jonathan Druart 2024-05-06 10:30:06 UTC
Created attachment 166198 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Comment 25 Jonathan Druart 2024-05-06 10:30:09 UTC
Created attachment 166199 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Comment 26 Jonathan Druart 2024-05-06 10:30:12 UTC
Created attachment 166200 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Comment 27 Jonathan Druart 2024-05-06 10:30:15 UTC
Created attachment 166201 [details] [review]
Bug 29948: (follow-up) Update system preference description and heading

This follow-up:
1. Updates the OPACAuthorIdentifiersAndInformation system preference
   description.
2. Changes the OPAC heading used on the bibliographic record and
   authority record detail pages from "Author identifiers/information"
   to "Author information". Identfiers are a subset of author information
   and having just "Author information" is sufficient. In addition,
   the authority record doesn't have to include identifiers.

Signed-off-by: David Nind <david@davidnind.com>
Comment 28 Jonathan Druart 2024-05-06 10:30:18 UTC
Created attachment 166202 [details] [review]
Bug 29948: Hide entry if empty
Comment 29 Jonathan Druart 2024-05-06 10:30:21 UTC
Created attachment 166203 [details] [review]
Bug 29948: Remove margin bottom for paragraph
Comment 30 Jonathan Druart 2024-05-06 10:30:42 UTC
(In reply to David Nind from comment #18)
> I identified these two issues (wasn't sure how to fix these):
> 
> 1. If there are no values in the authority record for these subfields, and
> they are selected in OPACAuthorIdentifiersAndInformation, they display the
> title without a value:
>    - URI 371$u (when no value displays as: URI:)
>    - Electronic email address 371$m (when no value displays as: Email
> address:)

Fixed.

> 2. Display of occupation information (374$a$s$t$u$v$0): there are extra
> lines between URI, Source of information, and Authority record control
> number or standard number. An HTML paragraph tag is used for each line, not
> sure if using another unordered list would work to display the information
> more cleanly.

Fixed.

> I added a follow-up to:
> 1. Update the system preference description.[1]
> 2. Change the heading "Author identifiers/information" to "Author
> information". Rational: Identifiers are a type of author information, so
> just having "Author information" is sufficient. The authority record doesn't
> have to include identifiers now.

Thanks!

> One other thing I noted:
> - The Publons ID now redirects to the Web of Science website and the Web of
> Science ResearcherID. However, the Publons ID is not the same number as the
> Web of Science ResearcherID. So we can't just change the URL and name. Happy
> to create a new bug to add the Web of Science ResearcherID as a new
> identifier.

Yes please, I will be happy to provide patch!
Comment 31 David Nind 2024-05-06 11:08:55 UTC
Created attachment 166205 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Comment 32 David Nind 2024-05-06 11:08:58 UTC
Created attachment 166206 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Comment 33 David Nind 2024-05-06 11:09:01 UTC
Created attachment 166207 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Comment 34 David Nind 2024-05-06 11:09:04 UTC
Created attachment 166208 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Comment 35 David Nind 2024-05-06 11:09:07 UTC
Created attachment 166209 [details] [review]
Bug 29948: (follow-up) Update system preference description and heading

This follow-up:
1. Updates the OPACAuthorIdentifiersAndInformation system preference
   description.
2. Changes the OPAC heading used on the bibliographic record and
   authority record detail pages from "Author identifiers/information"
   to "Author information". Identfiers are a subset of author information
   and having just "Author information" is sufficient. In addition,
   the authority record doesn't have to include identifiers.

Signed-off-by: David Nind <david@davidnind.com>
Comment 36 David Nind 2024-05-06 11:09:10 UTC
Created attachment 166210 [details] [review]
Bug 29948: Hide entry if empty

Signed-off-by: David Nind <david@davidnind.com>
Comment 37 David Nind 2024-05-06 11:09:13 UTC
Created attachment 166211 [details] [review]
Bug 29948: Remove margin bottom for paragraph

Signed-off-by: David Nind <david@davidnind.com>
Comment 38 David Nind 2024-05-06 13:02:05 UTC
Thanks Jonathan!

Have added Bug 36795 - Authority record identifier source codes (024$2) - code for Web of Science ResearcherID.
Comment 39 Nick Clemens (kidclamp) 2024-05-10 18:28:24 UTC
Created attachment 166594 [details] [review]
Bug 29948: Display authors information along with the identifiers

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 40 Nick Clemens (kidclamp) 2024-05-10 18:28:27 UTC
Created attachment 166595 [details] [review]
Bug 29948: OPACAuthorIdentifiersAndInformation

This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref.

It creates a new syspref OPACAuthorIdentifiersAndInformation and remove
OPACAuthorIdentifiers.
"identifiers" become an entry of the new syspref.

Test plan:
Select some entries in OPACAuthorIdentifiersAndInformation
Edit an authority record and enter data in the corresponding subfield
(the list is on the syspref entry)
Go to the biblio detail page or the authority detail page at the OPAC
and notice that the info you selected are correctly displayed.

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 41 Nick Clemens (kidclamp) 2024-05-10 18:28:29 UTC
Created attachment 166596 [details] [review]
Bug 29948: Allow to sort info

With this patch the different info can be ordered when editing the
syspref

Sponsored-by: Orex Digital

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 42 Nick Clemens (kidclamp) 2024-05-10 18:28:32 UTC
Created attachment 166597 [details] [review]
Bug 29948: Fix display of selected values

The values were correctly inserted but the display was not sorting
correctly

Signed-off-by: Signed-off-by: Hugo Agud <hagud@orex.es>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 43 Nick Clemens (kidclamp) 2024-05-10 18:28:34 UTC
Created attachment 166598 [details] [review]
Bug 29948: (follow-up) Update system preference description and heading

This follow-up:
1. Updates the OPACAuthorIdentifiersAndInformation system preference
   description.
2. Changes the OPAC heading used on the bibliographic record and
   authority record detail pages from "Author identifiers/information"
   to "Author information". Identfiers are a subset of author information
   and having just "Author information" is sufficient. In addition,
   the authority record doesn't have to include identifiers.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 44 Nick Clemens (kidclamp) 2024-05-10 18:28:36 UTC
Created attachment 166599 [details] [review]
Bug 29948: Hide entry if empty

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 45 Nick Clemens (kidclamp) 2024-05-10 18:28:39 UTC
Created attachment 166600 [details] [review]
Bug 29948: Remove margin bottom for paragraph

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 46 Katrin Fischer 2024-05-13 10:22:06 UTC
There is a slight regression with this patch. Before the patch the library could choose what codes to display, now they can no longer.
I did like the previous behavior because authorities is not something our libraries catalog themselves most of the time - they pull them from the national authority database and we update automatically when a change is made to the latest version of the authority record. Which means there can be all kinds of identifiers included that they might not know about.

I have added a patch that adds spans and classes to they can at least hide information using CSS if required.
Comment 47 Katrin Fischer 2024-05-13 10:23:13 UTC
... also rephrasing the system preference description.
Comment 48 Katrin Fischer 2024-05-13 12:02:13 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 49 Jonathan Druart 2024-05-13 14:00:12 UTC
Created attachment 166642 [details] [review]
Bug 29948: Adjust sysprefs.sql
Comment 50 Jonathan Druart 2024-05-13 14:00:33 UTC
Fixes t/db_dependent/check_sysprefs.t
Comment 51 Katrin Fischer 2024-05-13 14:10:43 UTC
Thank you, follow-up picked for main.
Comment 52 Fridolin Somers 2024-05-29 12:20:22 UTC
Not backported to 23.11.x