Bug 38085 - Untranslatable options in OPACAuthorIdentifiersAndInformation
Summary: Untranslatable options in OPACAuthorIdentifiersAndInformation
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 29948
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-03 21:04 UTC by Caroline Cyr La Rose
Modified: 2024-11-20 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:


Attachments
Bug 38085: Pick multiple_sortable options for translation (2.35 KB, patch)
2024-10-07 09:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38085: Pick multiple_sortable options for translation (2.42 KB, patch)
2024-10-07 14:24 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 38085: Pick multiple_sortable options for translation (2.47 KB, patch)
2024-10-25 14:25 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-10-03 21:04:30 UTC
When I translated the strings for OPACAuthorIdentifiersAndInformation in Weblate, the options for the system preference are not there. I also searched for "Activity", but there is no string "Activity (372$a$s$t)".
Comment 1 Jonathan Druart 2024-10-07 09:34:48 UTC
Created attachment 172448 [details] [review]
Bug 38085: Pick multiple_sortable options for translation

Bug 29948 added a "multiple_sortable" type for sysprefs, to have the
options sortable. But the options were not picked for translation.

This patch fixes it.

Test plan:
Run `cd misc/translator && perl translate update LANG` before and after
this patch. Notice that with this patch you see the different options of
OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg.
"Associated group (373$a$s$t$u$v$0)")
Translate the options
Install the translated version of the templates and confirm that the
strings appear translated on the interface.
Comment 2 Caroline Cyr La Rose 2024-10-07 14:24:32 UTC
Created attachment 172472 [details] [review]
Bug 38085: Pick multiple_sortable options for translation

Bug 29948 added a "multiple_sortable" type for sysprefs, to have the
options sortable. But the options were not picked for translation.

This patch fixes it.

Test plan:
Run `cd misc/translator && perl translate update LANG` before and after
this patch. Notice that with this patch you see the different options of
OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg.
"Associated group (373$a$s$t$u$v$0)")
Translate the options
Install the translated version of the templates and confirm that the
strings appear translated on the interface.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2024-10-07 14:24:48 UTC
Thanks Jonathan!
Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-25 14:25:08 UTC
Created attachment 173371 [details] [review]
Bug 38085: Pick multiple_sortable options for translation

Bug 29948 added a "multiple_sortable" type for sysprefs, to have the
options sortable. But the options were not picked for translation.

This patch fixes it.

Test plan:
Run `cd misc/translator && perl translate update LANG` before and after
this patch. Notice that with this patch you see the different options of
OPACAuthorIdentifiersAndInformation in the LANG-pref.po file (eg.
"Associated group (373$a$s$t$u$v$0)")
Translate the options
Install the translated version of the templates and confirm that the
strings appear translated on the interface.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Katrin Fischer 2024-10-25 14:42:26 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-20 23:32:13 UTC
Backported to 24.05.x for upcoming 24.05.06