Bug 38114

Summary: columns_settings.inc used when not needed
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36640    
Bug Blocks:    

Description Jonathan Druart 2024-10-08 09:53:33 UTC
columns_settings.inc is used from many templates, but sometimes it's not needed.

KohaTable - columns_settings.inc
kohaTable (DT REST API wrapper) - datatables.js

If we do not use KohaTable we should not include columns_settings.inc
Comment 1 Jonathan Druart 2024-10-08 09:55:54 UTC
% grep -l 'columns_settings.inc' **/*.tt **/*.inc | xargs grep -L 'KohaTable'

This could provide a first list, but it's not accurate. For instance:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt is a false positive (we use KohaTable from another js file)
Comment 2 Jonathan Druart 2024-11-28 15:47:17 UTC
columns_settings.inc is going to be removed on bug 26553.

*** This bug has been marked as a duplicate of bug 26553 ***