Bug 38114 - columns_settings.inc used when not needed
Summary: columns_settings.inc used when not needed
Status: RESOLVED DUPLICATE of bug 26553
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 36640
Blocks:
  Show dependency tree / graph
 
Reported: 2024-10-08 09:53 UTC by Jonathan Druart
Modified: 2024-11-28 15:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-08 09:53:33 UTC 
columns_settings.inc is used from many templates, but sometimes it's not needed.

KohaTable - columns_settings.inc
kohaTable (DT REST API wrapper) - datatables.js

If we do not use KohaTable we should not include columns_settings.inc
Comment 1 Jonathan Druart 2024-10-08 09:55:54 UTC 
% grep -l 'columns_settings.inc' **/*.tt **/*.inc | xargs grep -L 'KohaTable'

This could provide a first list, but it's not accurate. For instance:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt is a false positive (we use KohaTable from another js file)
Comment 2 Jonathan Druart 2024-11-28 15:47:17 UTC 
columns_settings.inc is going to be removed on bug 26553.

*** This bug has been marked as a duplicate of bug 26553 ***