Summary: | Edit button in bookings untranslatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to stable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, f.demians, jonathan.druart, marie.hedbom, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the 'Edit' and 'Cancel' actions for the bookings table for a record in the staff interface - these are now translatable.
|
Version(s) released in: |
25.05.00,24.11.04
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 38217 | ||
Attachments: |
Bug 38147: Fix Edit and Cancel translatability in booking table
Bug 38147: Fix Edit and Cancel translatability in booking table Bug 38147: Fix Edit and Cancel translatability in booking table Bug 38147: Fix Edit and Cancel translatability in booking table Bug 38147: Fix Edit and Cancel translatability in booking table |
Description
Caroline Cyr La Rose
2024-10-10 21:09:06 UTC
Created attachment 172769 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table No idea why they are not picked by the translator script, but this patch is fixing the problem. See comment 0 for a test plan. I can't figure out how to update the language files - I thought I had it worked out! This is what I did, but the "Edit" action is still "Edit": 1. Install a language: 1.1 koha-translate --install fr-CA --dev kohadev 1.2 restart_all 1.3 Enable the language: Administration > System preferences > I18N/L10N > StaffInterfaceLanguages > select the language you want to enable 1.4 Choose the language from the staff interface footer 2. Apply the patch. 3. Update the language with the string changes: 3.1 gulp po:update --lang fr-CA 3.2 koha-translate --update fr-CA --dev kohadev 3.3 restart_all I must be missing a step somewhere! Created attachment 173013 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. After the patch, this is now working for the "Edit" action - it is now "Modifier". However, after the patch the "Cancel" action, which was previously "Annuler" is now "Cancel" when Français is set as the language. Created attachment 176044 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Sorry for the delay I totally lost track of this one. (In reply to Jonathan Druart from comment #6) > Sorry for the delay I totally lost track of this one. Very easy to do with the volume of bugzilla email! I'll leave testing until I can install a language again. I'm not sure whether it is just me, but if I try to install a language in KTD (I tried a couple of other languages as well), I get this error: koha-translate --install fr-CA --dev kohadev Can't use an undefined value as a HASH reference at /kohadevbox/koha/misc/ translator/tmpl_process3.pl line 134. You can change interface language, however, if you go to any record page in the staff interface: Template process failed: file error - parse error - cat-toolbar.inc line 132: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 134 This is on main with everything up to date (koha repository, koha-testing-docker repository, ktd pull). Created attachment 176057 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Signed-off-by: David Nind <david@davidnind.com> Note: Jonathan and Katron fixed the issues with installing translations with a follow-up patch to bug 38684. Katrin! (In reply to David Nind from comment #9) > Note: Jonathan and Katron fixed the issues with installing translations with > a follow-up patch to bug 38684. That should be Katrin! Created attachment 176199 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks for the fix here Jonathan. Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.04 |