I can't find where to translate the "Edit" button in the bookings page. In Weblate, I tried looking through all the strings with the location "bookings", and I can't find it. https://translate.koha-community.org/search/koha/main/-/fr_CA/?q=+location%3Abookings+&sort_by=-priority%2Cposition&checksum= To get there: 1. In the staff interface, go to a biblio record 2. Click 'Items' in the left side menu 3. Choose Bookable: Yes and Update 4. Click 'Place booking' 5. Fill out the form and Submit 6. Click 'Bookings' in the left side menu --> Edit button in the table at the bottom 7. Install new language ./misc/translate/install fr-CA 8. Enable the new language in the StaffInterfaceLanguages system preference 9. Change the interface to the new language 10. View the bookings page --> Edit button is in English 11. Check the .po files for bookings locations --> No "Edit" string with "/bookings" location
Created attachment 172769 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table No idea why they are not picked by the translator script, but this patch is fixing the problem. See comment 0 for a test plan.
I can't figure out how to update the language files - I thought I had it worked out! This is what I did, but the "Edit" action is still "Edit": 1. Install a language: 1.1 koha-translate --install fr-CA --dev kohadev 1.2 restart_all 1.3 Enable the language: Administration > System preferences > I18N/L10N > StaffInterfaceLanguages > select the language you want to enable 1.4 Choose the language from the staff interface footer 2. Apply the patch. 3. Update the language with the string changes: 3.1 gulp po:update --lang fr-CA 3.2 koha-translate --update fr-CA --dev kohadev 3.3 restart_all I must be missing a step somewhere!
Created attachment 173013 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan.
After the patch, this is now working for the "Edit" action - it is now "Modifier". However, after the patch the "Cancel" action, which was previously "Annuler" is now "Cancel" when Français is set as the language.
Created attachment 176044 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan.
Sorry for the delay I totally lost track of this one.
(In reply to Jonathan Druart from comment #6) > Sorry for the delay I totally lost track of this one. Very easy to do with the volume of bugzilla email! I'll leave testing until I can install a language again. I'm not sure whether it is just me, but if I try to install a language in KTD (I tried a couple of other languages as well), I get this error: koha-translate --install fr-CA --dev kohadev Can't use an undefined value as a HASH reference at /kohadevbox/koha/misc/ translator/tmpl_process3.pl line 134. You can change interface language, however, if you go to any record page in the staff interface: Template process failed: file error - parse error - cat-toolbar.inc line 132: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 134 This is on main with everything up to date (koha repository, koha-testing-docker repository, ktd pull).
Created attachment 176057 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Signed-off-by: David Nind <david@davidnind.com>
Note: Jonathan and Katron fixed the issues with installing translations with a follow-up patch to bug 38684.
Katrin! (In reply to David Nind from comment #9) > Note: Jonathan and Katron fixed the issues with installing translations with > a follow-up patch to bug 38684. That should be Katrin!
Created attachment 176199 [details] [review] Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the fix here Jonathan.
Pushed for 25.05! Well done everyone, thank you!