Bug 38232

Summary:	Materials specified note un-checks Forgive overdue charges box
Product:	Koha	Reporter:	hebah
Component:	Circulation	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Needs Signoff ---	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 38232: Pass exemptfine value into circ-needsconfirmation-modal form

Description hebah 2024-10-22 21:33:02 UTC

To recreate:
FinesMode on, have an item with a materials specified note (952$3).
Check in item with 'forgive overdue charge' selected, no materials note, box stays checked. Materials note checkin deselects the box.

There have been similar issues with things deselecting a check in box (wrong transfer, bug 36199), and I know materials specified notes can interact with things like since-fixed bug 29671 (materials note items deselecting book drop mode), or current bug 37424 (batch checkout silently failing with materials notes)

Comment 1 Lucas Gass (lukeg) 2024-10-23 14:48:00 UTC

I cannot reproduce this in current main.

Comment 2 Lucas Gass (lukeg) 2024-11-08 16:13:22 UTC

One extra step to recreate in main is to make sure `CircConfirmItemParts` is on.

Comment 3 Lucas Gass (lukeg) 2024-11-08 16:22:46 UTC

Created attachment 174283 [details] [review]
Bug 38232: Pass exemptfine value into circ-needsconfirmation-modal form

To test:
1. FinesMode on
2. CircConfirmItemParts on
3. have an item with a materials specified note (952$3)
4. Check in item with 'forgive overdue charge' selected, no materials note, box stays checked.
5. Check in item with 'forgive overdue charge' selected, with a material note, Materials note checkin deselects the box.
6. APPLY PATCH
7. Try steps 4-5 again, the correct value should be retained in the 'forgive overdue charge' checkbox.