Created attachment 169379 [details] Screenshot where the 952$3 should display As noted in 15718 and 23780, when using the batch checkout feature, there’s no preview of the 952$3 in the confirm checkout screen to let you know why the checkout needs confirmation, but also the checkout silently fails even when selecting "Checkout or renew". It sounded most similar to 30995, but my user has the force_checkout permission, so that doesn’t apply. Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. When you select “Checkout or renew,” you are taken back to the batch check out screen, but the item with the 952$3 is NOT checked out to the patron, nor are you given any warning that an error occurred.
Created attachment 169438 [details] [review] Bug 37424: Display additional materials note in batch checkout This patch adds a missing conditional for ADDITIONAL_MATERIALS to the batch checkout table Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. Do not confirm checkout 7. Apply patch 8. Try again, the materials note should show this time 9. Confirm checkout 10. Success! Item is checked out
Created attachment 169447 [details] [review] Bug 37424: Display additional materials note in batch checkout This patch adds a missing conditional for ADDITIONAL_MATERIALS to the batch checkout table Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. Do not confirm checkout 7. Apply patch 8. Try again, the materials note should show this time 9. Confirm checkout 10. Success! Item is checked out Signed-off-by: Catrina Berka <catrina@bywatersolutions.com>
Hi Catrina. It looks like you've signed this off. So that you get the credit on the dashboard (https://dashboard.koha-community.org/), could you update the status to "Signed off"? (It will also move the bug into the QA queue.) David