Summary: | Replace instances of obsolete Bootstrap class "pull-right" | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to stable --- | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38608 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38026 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes some CSS from the Bootstrap 5 upgrade:
- Removes instances of the pre-Bootstrap-5 class "pull-right" (Bootstrap 5 menus have better responsive behavour).
- Adds "dropdown-item" classes to some menu items that lacked it.
- Adds some custom style for the "Filter" form in the patron permissions toolbar (it is now correctly aligned).
(This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
|
|
Version(s) released in: |
25.05.00,24.11.03
|
Circulation function: | |
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 38285: Replace instances of obsolete Bootstrap class "pull-right"
Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" |
Description
Owen Leonard
2024-10-29 10:24:58 UTC
Created attachment 174079 [details] [review] Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" This patch fixes instances where the pre-Bootstrap-5 class "pull-right" was missed during the upgrade. Most cases were on dropdown menus, and in all of these cases the class can be removed because Bootstrap 5 menus have better responsive behavior. Other changes: Added "dropdown-item" classes to some menu items which lacked it; Added some custom style for the "Filter" form in the patron permissions toolbar. To test, apply the patch and rebuild the staff interface CSS. Test that the following menus look correct and work correctly: - Catalog -> Bibliographic details page -> Holdings table: The "Edit" secondary menu shown for each item (requires that the LocalCoverImages system preference be enabled. - Administration -> Z39.50 servers: The "Actions" menu for each server in the list of servers. - Circulation -> Article requests: The "Actions" menu for each title and under each tab (New, Pending, and Processing). - Tools -> Patron lists: "Actions" menu. - Administration -> Plugins: "Actions" menu (requires that you have at least one plugin installed). - Reports -> Saved SQL reports: The secondary menu on each saved report's "Run" button . - Cataloging -> Rotating collections: "Actions" menu. - Serials -> Subscription search results: In the "Open" tab, the secondary menu on the "Serial receive" button on each subscription. In the "Closed" tab, the "Actions" menu. - Acquistions -> Suggestions: The secondary menu on each title's "Edit" button. - Tools -> HTML customizations: The secondary menu on the "New entry" button; The secondary menu on each entry's "Edit" button; Edit entry -> The secondary menu on the "Save" button. - Cataloging -> Stock rotation: The "Manage" menu on each rota. A non-menu change: - Patrons -> Patron details -> More -> Set permissions: CSS has been added to correctly align the "Filter" menu. Sponsored-by: Athens County Public Libraries Created attachment 175023 [details] [review] Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" This patch fixes instances where the pre-Bootstrap-5 class "pull-right" was missed during the upgrade. Most cases were on dropdown menus, and in all of these cases the class can be removed because Bootstrap 5 menus have better responsive behavior. Other changes: Added "dropdown-item" classes to some menu items which lacked it; Added some custom style for the "Filter" form in the patron permissions toolbar. To test, apply the patch and rebuild the staff interface CSS. Test that the following menus look correct and work correctly: - Catalog -> Bibliographic details page -> Holdings table: The "Edit" secondary menu shown for each item (requires that the LocalCoverImages system preference be enabled. - Administration -> Z39.50 servers: The "Actions" menu for each server in the list of servers. - Circulation -> Article requests: The "Actions" menu for each title and under each tab (New, Pending, and Processing). - Tools -> Patron lists: "Actions" menu. - Administration -> Plugins: "Actions" menu (requires that you have at least one plugin installed). - Reports -> Saved SQL reports: The secondary menu on each saved report's "Run" button . - Cataloging -> Rotating collections: "Actions" menu. - Serials -> Subscription search results: In the "Open" tab, the secondary menu on the "Serial receive" button on each subscription. In the "Closed" tab, the "Actions" menu. - Acquistions -> Suggestions: The secondary menu on each title's "Edit" button. - Tools -> HTML customizations: The secondary menu on the "New entry" button; The secondary menu on each entry's "Edit" button; Edit entry -> The secondary menu on the "Save" button. - Cataloging -> Stock rotation: The "Manage" menu on each rota. A non-menu change: - Patrons -> Patron details -> More -> Set permissions: CSS has been added to correctly align the "Filter" menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> *** Bug 38608 has been marked as a duplicate of this bug. *** QA by RM Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.03 |