Bug 38608 - Improve style of permissions filter form
Summary: Improve style of permissions filter form
Status: RESOLVED DUPLICATE of bug 38285
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 38026 (view as bug list)
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-03 16:21 UTC by Owen Leonard
Modified: 2024-12-05 17:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Screenshot showing the form field (22.05 KB, image/png)
2024-12-03 16:21 UTC, Owen Leonard
Details
Bug 38608: Improve style of permissions filter form (2.31 KB, patch)
2024-12-03 16:28 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-12-03 16:21:11 UTC
Created attachment 175084 [details]
Screenshot showing the form field

Following the Bootstrap upgrade the filter form on the user permissions page looks a little off.
Comment 1 Owen Leonard 2024-12-03 16:28:08 UTC
Created attachment 175085 [details] [review]
Bug 38608: Improve style of permissions filter form

This patch makes some small markup and style changes in order to make
the filter form on the user permissions page fit better in the toolbar.

To test, apply the patch and rebuild the staff interface CSS. You may
need to clear your browser cache.

- Search for a patron in the staff interface and view their detail page
- In the toolbar, choose More -> Set permissions.
- In the permissions toolbar, confirm that the form field isn't
  oversized and that the label is aligned well.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-12-04 21:06:16 UTC
Hi Owen.

You fixed this in bug 38285 - with almost exactly the same change (the only difference is the size - 10 in this patch, 20 in the other one). 8-)

So is this a duplicate?

David
Comment 3 David Nind 2024-12-04 21:08:57 UTC
*** Bug 38026 has been marked as a duplicate of this bug. ***
Comment 4 Owen Leonard 2024-12-05 13:23:49 UTC
(In reply to David Nind from comment #2)
 
> You fixed this in bug 38285 - with almost exactly the same change

I'm expected to remember EVERY patch? In the PAST??

*** This bug has been marked as a duplicate of bug 38285 ***
Comment 5 David Nind 2024-12-05 17:27:29 UTC
(In reply to Owen Leonard from comment #4)
> (In reply to David Nind from comment #2)
>  
> > You fixed this in bug 38285 - with almost exactly the same change
> 
> I'm expected to remember EVERY patch? In the PAST??
> 

LOL.

Yes, yes you are! 8-)