Summary: | Checkbox/label for search filters incorrectly aligned | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | minor | ||
Priority: | P5 - low | CC: | julian.maurice, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 17170, 35402 | ||
Bug Blocks: | 39398 | ||
Attachments: |
Bug 38294: Fix layout of checkbox/label when editing search filters
Bug 38294: Fix layout of checkbox/label when editing search filters Bug 38294: Fix layout of checkbox/label when editing search filters |
Description
Jonathan Druart
2024-10-30 09:35:37 UTC
Created attachment 179555 [details] [review] Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries Created attachment 179627 [details] [review] Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Because I can't read, I kept clicking the "Edit filter" button, which pops up a modal with the labels and checkboxes on different lines, rather than "Edit search." I'd happily sign off a patch that fixed "Edit filter." Created attachment 180438 [details] [review] Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed for 25.05! Well done everyone, thank you! |