Bug 38294

Summary: Checkbox/label for search filters incorrectly aligned
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Julian Maurice <julian.maurice>
Severity: minor    
Priority: P5 - low CC: julian.maurice, phil
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 17170, 35402    
Bug Blocks: 39398    
Attachments: Bug 38294: Fix layout of checkbox/label when editing search filters
Bug 38294: Fix layout of checkbox/label when editing search filters
Bug 38294: Fix layout of checkbox/label when editing search filters

Description Jonathan Druart 2024-10-30 09:35:37 UTC
https://snipboard.io/vBcSKs.jpg
Comment 1 Jonathan Druart 2024-10-30 09:36:14 UTC
Coming from bug 35402?
Comment 2 Owen Leonard 2025-03-20 16:54:17 UTC
Created attachment 179555 [details] [review]
Bug 38294: Fix layout of checkbox/label when editing search filters

This patch makes a minor markup change in order to improve the alignment
of controls for editing a search filter in the staff interface.

To test, apply the patch and make sure the SavedSearchFilters system
preference is enabled.

- In the staff client catalog, perform a search.
- At the top of the search results, click "Save search as filter".
- Fill out the form and save the search filter.
- Go to Administration -> Search filters.
- Click the "Edit search" button for your filter.
- You should be returned to the advanced search page and there should be
  an "Editing filter" form at the top. The "Show in OPAC" and "Show in
  staff interface" labels and checkboxes should be aligned neatly with
  the buttons in the toolbar.

Sponsored-by: Athens County Public Libraries
Comment 3 Phil Ringnalda 2025-03-21 15:55:38 UTC
Created attachment 179627 [details] [review]
Bug 38294: Fix layout of checkbox/label when editing search filters

This patch makes a minor markup change in order to improve the alignment
of controls for editing a search filter in the staff interface.

To test, apply the patch and make sure the SavedSearchFilters system
preference is enabled.

- In the staff client catalog, perform a search.
- At the top of the search results, click "Save search as filter".
- Fill out the form and save the search filter.
- Go to Administration -> Search filters.
- Click the "Edit search" button for your filter.
- You should be returned to the advanced search page and there should be
  an "Editing filter" form at the top. The "Show in OPAC" and "Show in
  staff interface" labels and checkboxes should be aligned neatly with
  the buttons in the toolbar.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Phil Ringnalda 2025-03-21 15:57:37 UTC
Because I can't read, I kept clicking the "Edit filter" button, which pops up a modal with the labels and checkboxes on different lines, rather than "Edit search." I'd happily sign off a patch that fixed "Edit filter."
Comment 5 Julian Maurice 2025-04-03 08:17:34 UTC
Created attachment 180438 [details] [review]
Bug 38294: Fix layout of checkbox/label when editing search filters

This patch makes a minor markup change in order to improve the alignment
of controls for editing a search filter in the staff interface.

To test, apply the patch and make sure the SavedSearchFilters system
preference is enabled.

- In the staff client catalog, perform a search.
- At the top of the search results, click "Save search as filter".
- Fill out the form and save the search filter.
- Go to Administration -> Search filters.
- Click the "Edit search" button for your filter.
- You should be returned to the advanced search page and there should be
  an "Editing filter" form at the top. The "Show in OPAC" and "Show in
  staff interface" labels and checkboxes should be aligned neatly with
  the buttons in the toolbar.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Katrin Fischer 2025-04-11 07:55:44 UTC
Pushed for 25.05!

Well done everyone, thank you!