Created attachment 179556 [details] Screenshot of the proposed updated interface I have a number of style and layout changes I'd like to make to the staff interface's advanced search form.
Created attachment 179557 [details] Screenshot of the proposed updated interface -- more options
Created attachment 179558 [details] Screenshot of the proposed updated interface -- UNIMARC For the UNIMARC version I wanted to be able to break up the UNIMARC-specific search fields into smaller chunks so they could be displayed in a grid too. In this screenshot you can see I split the "Coded fields" section into two: "Coded fields" and "More coded fields" but that seems a little silly. Perhaps someone could think of a more intelligent way to organize those form fields so that each section could have a more descriptive name? I'm also interested in giving labels to the two "Picture" fields. Are the terms "Graphics type" and "Graphics support" sensible to display to the user?
Created attachment 179615 [details] Screenshot of the proposed updated interface -- Elasticsearch
From a MARC21 user: looks good! Makes it all look nicer and clearer :-) Out of curiosity: are you leaving the drop-down lists as they are for this piece of work, or are they going to become more flexible like the Item search picklists?
(In reply to Aude Charillon from comment #4) > Out of curiosity: are you leaving the drop-down lists as they are for this > piece of work, or are they going to become more flexible like the Item > search picklists? I didn't intend to make that kind of change. In fact I'm not sure that kind of interface is relevant here? In item search it works well because it's tied to predefined lists of things. I'm open to the idea if someone could make a good case for it but it would definitely be another bug.
Created attachment 179833 [details] [review] Bug 39398: Improve style and layout of staff interface advanced search form This patch updates the staff interface advanced search form to make it more responsive and to style it similarly to the item search form. To test, apply the patch and rebuild the staff interface CSS. - Go to the advanced search page in the staff interface. - Test the layout at various widths. Everything should adjust well. - Test in the "More options" view. - Test that adding and removing fields works correctly. - Test when using Zebra and Elasticsearch (SearchEngine system preference). - With Elasticsearch, test with ElasticsearchMARCFormat set to "Searchable array". - Test with IncludeSeeFromInSearches enabled. - Test using both MARC21 and UNIMARC. - Confirm that searching works correctly in all cases. Sponsored-by: Athens County Public Libraries
I don't think this is necessarily ready for signoff, but I wanted to send the patch so folks could test. I think it especially needs confirmation that searching is working correctly I'd love to get some opinions from UNIMARC libraries about how we might better break up the options which were previously grouped under the "Afficher les filtres sur les données codées" link.
Love it ! I noted an extra <p> under the "Subtype limits" which offset the Audience label. With more test, I noted that clicking the checkbox of the itemtypes doesn't get check, we need to click the images to do so.
Created attachment 180975 [details] [review] Bug 39398: (follow-up) Fix click handling of itype/ccode/loc checkboxes
I think this is a worthwhile improvement and I'd love to get more eyes on it.
Created attachment 184940 [details] [review] Bug 39398: (follow-up) Fix click handling of itype/ccode/loc checkboxes
Created attachment 188480 [details] [review] Bug 39398: Improve style and layout of staff interface advanced search form This patch updates the staff interface advanced search form to make it more responsive and to style it similarly to the item search form. To test, apply the patch and rebuild the staff interface CSS. - Go to the advanced search page in the staff interface. - Test the layout at various widths. Everything should adjust well. - Test in the "More options" view. - Test that adding and removing fields works correctly. - Test when using Zebra and Elasticsearch (SearchEngine system preference). - With Elasticsearch, test with ElasticsearchMARCFormat set to "Searchable array". - Test with IncludeSeeFromInSearches enabled. - Test using both MARC21 and UNIMARC. - Confirm that searching works correctly in all cases. Sponsored-by: Athens County Public Libraries
Created attachment 188481 [details] [review] Bug 39398: (follow-up) Fix click handling of itype/ccode/loc checkboxes
Created attachment 190483 [details] [review] Bug 39398: Improve style and layout of staff interface advanced search form This patch updates the staff interface advanced search form to make it more responsive and to style it similarly to the item search form. To test, apply the patch and rebuild the staff interface CSS. - Go to the advanced search page in the staff interface. - Test the layout at various widths. Everything should adjust well. - Test in the "More options" view. - Test that adding and removing fields works correctly. - Test when using Zebra and Elasticsearch (SearchEngine system preference). - With Elasticsearch, test with ElasticsearchMARCFormat set to "Searchable array". - Test with IncludeSeeFromInSearches enabled. - Test using both MARC21 and UNIMARC. - Confirm that searching works correctly in all cases. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190484 [details] [review] Bug 39398: (follow-up) Fix click handling of itype/ccode/loc checkboxes Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. The issues noted below happened before the patch as well, so are existing behavours. 2. I didn't really test ElasticsearchMARCFormat set to "Searchable array" and IncludeSeeFromInSearches, as I'm not sure what I'm looking for. Had them enabled though. MARC21 and UNIMARC - Zebra and Elasticsearch - quotes around search term ============================================ 1. Search so that you get no results (with or without more options toggled): - Keyword: a - Keyword for UNIMARC: sdfg - Subtype: Audience = Preschool (or primary for UNIMARC) 2. You get no results 3. Click "Edit this search" 4. Note that the keyword (a or sdfg) has quotes around it 5. Click search again 6. Still no results 7. Click "Edit this search" again 8. Note that there are now two sets of quotes around the a: ""a"" 9. If you keep repeating this, you get more quotes 10. Not sure if this actually makes any difference or not UNIMARC - Zebra and Elasticsearch ================================= 1. Under the 'Picture' options, there are two dropdown lists, starting with Any but with different values. There are no field labels shown. Maybe call them what UNIMARC field 116 builder calls them? (https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-online-ed/ page 120) - Specific material designation (or Material) (collage, drawing, etc) - Primary support material (or Support material) (canvas, etc) - Maybe instead of 'Picture' the heading should be called 'Graphics' - Definitely something to ask UNIMARC people about 2. Enter a as a keyword search, under coded fields for audience select a value (for example, juvenile, general), and click search: - After the search results are shown, click 'Edit this search' - Note that there is now an "Other limits" options area with ta:a and a tick (between location and availability options and sorting options) - If you select other values from other search options, these are shown under "Other limits" with codes, and the values you selected aren't pre-populated in the dropdown lists 3. I could replicate the Zebra (MARC21 and UNIMARC) issue with quotes around the search term when there are no results. To start KTD with UNIMARC = edit .env file and change KOHA_MARC_FLAVOUR=UNIMARC or start up KTD with: KOHA_MARC_FLAVOUR=UNIMARC ktd --es7 up To reindex Elasticsearch: koha-elasticsearch --rebuild -d -b -a kohadev