Bug 38294 - Checkbox/label for search filters incorrectly aligned
Summary: Checkbox/label for search filters incorrectly aligned
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 17170 35402
Blocks: 39398
  Show dependency treegraph
 
Reported: 2024-10-30 09:35 UTC by Jonathan Druart
Modified: 2025-03-21 15:57 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38294: Fix layout of checkbox/label when editing search filters (1.94 KB, patch)
2025-03-20 16:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38294: Fix layout of checkbox/label when editing search filters (1.99 KB, patch)
2025-03-21 15:55 UTC, Phil Ringnalda
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-30 09:35:37 UTC
https://snipboard.io/vBcSKs.jpg
Comment 1 Jonathan Druart 2024-10-30 09:36:14 UTC
Coming from bug 35402?
Comment 2 Owen Leonard 2025-03-20 16:54:17 UTC
Created attachment 179555 [details] [review]
Bug 38294: Fix layout of checkbox/label when editing search filters

This patch makes a minor markup change in order to improve the alignment
of controls for editing a search filter in the staff interface.

To test, apply the patch and make sure the SavedSearchFilters system
preference is enabled.

- In the staff client catalog, perform a search.
- At the top of the search results, click "Save search as filter".
- Fill out the form and save the search filter.
- Go to Administration -> Search filters.
- Click the "Edit search" button for your filter.
- You should be returned to the advanced search page and there should be
  an "Editing filter" form at the top. The "Show in OPAC" and "Show in
  staff interface" labels and checkboxes should be aligned neatly with
  the buttons in the toolbar.

Sponsored-by: Athens County Public Libraries
Comment 3 Phil Ringnalda 2025-03-21 15:55:38 UTC
Created attachment 179627 [details] [review]
Bug 38294: Fix layout of checkbox/label when editing search filters

This patch makes a minor markup change in order to improve the alignment
of controls for editing a search filter in the staff interface.

To test, apply the patch and make sure the SavedSearchFilters system
preference is enabled.

- In the staff client catalog, perform a search.
- At the top of the search results, click "Save search as filter".
- Fill out the form and save the search filter.
- Go to Administration -> Search filters.
- Click the "Edit search" button for your filter.
- You should be returned to the advanced search page and there should be
  an "Editing filter" form at the top. The "Show in OPAC" and "Show in
  staff interface" labels and checkboxes should be aligned neatly with
  the buttons in the toolbar.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Phil Ringnalda 2025-03-21 15:57:37 UTC
Because I can't read, I kept clicking the "Edit filter" button, which pops up a modal with the labels and checkboxes on different lines, rather than "Edit search." I'd happily sign off a patch that fixed "Edit filter."