Bug 38347

Summary: Fix style of sidebar form submit button on bookings to collect page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Lisette Scheer <lisette>
Severity: minor    
Priority: P5 - low CC: david, lisette
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the style for the submit button on the bookings to collect page (Circulation > Bookings to collect). It now has the same yellow "primary" style as other submit buttons, and it fills the width of the sidebar.
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

Description Owen Leonard 2024-11-04 14:55:33 UTC
On the bookings to collect page the style of the submit button is incorrect.
Comment 1 Owen Leonard 2024-11-04 15:00:24 UTC
Created attachment 173928 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-11-30 17:13:28 UTC
The patch no longer applies 8-(...

git bz apply 38347

Bug 38347 - Fix style of sidebar form submit button on bookings to collect page

173928 - Bug 38347: Fix style of sidebar form submit button on bookings to collect page

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Comment 3 Owen Leonard 2024-12-02 12:57:15 UTC
Created attachment 175053 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

NOTE: This patch contains indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
Comment 4 David Nind 2024-12-02 23:13:11 UTC
Created attachment 175063 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

NOTE: This patch contains indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Lisette Scheer 2024-12-06 16:24:24 UTC
Created attachment 175268 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

NOTE: This patch contains indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

There was a stray div removed. 

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-12-23 09:37:21 UTC
Pushed for 25.05!

Well done everyone, thank you!