Bug 38347 - Fix style of sidebar form submit button on bookings to collect page
Summary: Fix style of sidebar form submit button on bookings to collect page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2024-11-04 14:55 UTC by Owen Leonard
Modified: 2024-12-02 23:13 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38347: Fix style of sidebar form submit button on bookings to collect page (5.85 KB, patch)
2024-11-04 15:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38347: Fix style of sidebar form submit button on bookings to collect page (8.31 KB, patch)
2024-12-02 12:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38347: Fix style of sidebar form submit button on bookings to collect page (8.36 KB, patch)
2024-12-02 23:13 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-11-04 14:55:33 UTC
On the bookings to collect page the style of the submit button is incorrect.
Comment 1 Owen Leonard 2024-11-04 15:00:24 UTC
Created attachment 173928 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-11-30 17:13:28 UTC
The patch no longer applies 8-(...

git bz apply 38347

Bug 38347 - Fix style of sidebar form submit button on bookings to collect page

173928 - Bug 38347: Fix style of sidebar form submit button on bookings to collect page

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 38347: Fix style of sidebar form submit button on bookings to collect page
Comment 3 Owen Leonard 2024-12-02 12:57:15 UTC
Created attachment 175053 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

NOTE: This patch contains indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
Comment 4 David Nind 2024-12-02 23:13:11 UTC
Created attachment 175063 [details] [review]
Bug 38347: Fix style of sidebar form submit button on bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

NOTE: This patch contains indentation changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>