Bug 38395

Summary: Title is not displayed in hold history when bibliographic record is deleted
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: PatronsAssignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to stable --- QA Contact: Matt Blenkinsop <matt.blenkinsop>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kebliss, kyle.m.hall, matt.blenkinsop, nick, paul.derscheid
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.05
Circulation function:
Bug Depends on: 30648, 39710    
Bug Blocks:    
Attachments: Bug 38395: Display bibliographic data for deleted biblios in holds history
Bug 38395: Display bibliographic data for deleted biblios in holds history
Bug 38395: Only embed deleted_biblios for old holds
Bug 38395: Only embed deleted_biblios for old holds
Bug 38395: Display bibliographic data for deleted biblios in holds history
Bug 38395: Only embed deleted_biblios for old holds

Description Andrew Fuerste-Henry 2024-11-07 15:20:22 UTC
Bug 30648 made Koha retain deleted_biblionumber in reserves and old_reserves, but did not make Koha use that deleted_biblionumber to display a title in holds history.

To recreate:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history, see "No bibliographic record"
 - use a report to look at your hold in old_reserves, confirm your deleted biblionumber is in the table
Comment 1 Nick Clemens (kidclamp) 2025-04-23 14:02:50 UTC
Created attachment 181373 [details] [review]
Bug 38395: Display bibliographic data for deleted biblios in holds history

This patch adds deleted_biblio to the patron holds api and adjsuts the display to
shwo the data for deleted items

To test:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history
 - you see a line with no title or author
 - apply patch, yarn build, restart_all
 - reload patron hold history
 - success, you see deleted title info
 - enable OPACHoldsHistory preference
 - sign in to OPAC as patron
 - confirm holds history shows deleted title info
Comment 2 Roman Dolny 2025-04-23 14:38:25 UTC
Created attachment 181380 [details] [review]
Bug 38395: Display bibliographic data for deleted biblios in holds history

This patch adds deleted_biblio to the patron holds api and adjsuts the display to
shwo the data for deleted items

To test:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history
 - you see a line with no title or author
 - apply patch, yarn build, restart_all
 - reload patron hold history
 - success, you see deleted title info
 - enable OPACHoldsHistory preference
 - sign in to OPAC as patron
 - confirm holds history shows deleted title info

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Andrew Fuerste-Henry 2025-04-23 14:59:30 UTC
This patch makes the page fail when the patron has an active hold on a non-deleted biblio.
Comment 4 Nick Clemens (kidclamp) 2025-04-23 15:05:08 UTC
Created attachment 181388 [details] [review]
Bug 38395: Only embed deleted_biblios for old holds
Comment 5 Roman Dolny 2025-04-23 20:34:36 UTC
Created attachment 181397 [details] [review]
Bug 38395: Only embed deleted_biblios for old holds

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 6 Matt Blenkinsop 2025-05-01 09:55:55 UTC
Created attachment 181824 [details] [review]
Bug 38395: Display bibliographic data for deleted biblios in holds history

This patch adds deleted_biblio to the patron holds api and adjsuts the display to
shwo the data for deleted items

To test:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history
 - you see a line with no title or author
 - apply patch, yarn build, restart_all
 - reload patron hold history
 - success, you see deleted title info
 - enable OPACHoldsHistory preference
 - sign in to OPAC as patron
 - confirm holds history shows deleted title info

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 7 Matt Blenkinsop 2025-05-01 09:55:58 UTC
Created attachment 181825 [details] [review]
Bug 38395: Only embed deleted_biblios for old holds

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 8 Katrin Fischer 2025-05-02 06:55:03 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 9 Andrew Fuerste-Henry 2025-05-02 12:06:18 UTC
Can this please be backported to 24.11?
Comment 10 Paul Derscheid 2025-05-26 07:25:19 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05