To recreate: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history, error [2025/04/23 11:43:28] [WARN] OpenAPI >>> GET api/v1/patrons/5/holds [{"message":"Expected integer - got null.","path":"\/body\/3\/biblio_id"},{"message":"Expected integer - got null.","path":"\/body\/4\/biblio_id"}]
Created attachment 181367 [details] [review] Bug 39710: Unit test
Created attachment 181368 [details] [review] Bug 39710: Handle deleted biblios in holds history To test: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history, error [2025/04/23 11:43:28] [WARN] OpenAPI >>> GET api/v1/patrons/5/holds [{"message":"Expected integer - got null.","path":"\/body\/3\/biblio_id"},{"message":"Expected integer - got null.","path":"\/body\/4\/biblio_id"}] - apply patch, yarn build, restart_all - reload patron hold history - success - enable OPACHoldsHistory preference - sign in to OPAC as patron - confirm holds history can be loaded
Created attachment 181374 [details] [review] Bug 39710: Unit test Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181375 [details] [review] Bug 39710: Handle deleted biblios in holds history To test: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history, error [2025/04/23 11:43:28] [WARN] OpenAPI >>> GET api/v1/patrons/5/holds [{"message":"Expected integer - got null.","path":"\/body\/3\/biblio_id"},{"message":"Expected integer - got null.","path":"\/body\/4\/biblio_id"}] - apply patch, yarn build, restart_all - reload patron hold history - success - enable OPACHoldsHistory preference - sign in to OPAC as patron - confirm holds history can be loaded Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181828 [details] [review] Bug 39710: Unit test Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Created attachment 181829 [details] [review] Bug 39710: Handle deleted biblios in holds history To test: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history, error [2025/04/23 11:43:28] [WARN] OpenAPI >>> GET api/v1/patrons/5/holds [{"message":"Expected integer - got null.","path":"\/body\/3\/biblio_id"},{"message":"Expected integer - got null.","path":"\/body\/4\/biblio_id"}] - apply patch, yarn build, restart_all - reload patron hold history - success - enable OPACHoldsHistory preference - sign in to OPAC as patron - confirm holds history can be loaded Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!
Can this please be backported to 24.11?