Bug 38395 - Title is not displayed in hold history when bibliographic record is deleted
Summary: Title is not displayed in hold history when bibliographic record is deleted
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Matt Blenkinsop
URL:
Keywords:
Depends on: 30648 39710
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-07 15:20 UTC by Andrew Fuerste-Henry
Modified: 2025-05-26 07:31 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.05
Circulation function:


Attachments
Bug 38395: Display bibliographic data for deleted biblios in holds history (8.01 KB, patch)
2025-04-23 14:02 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 38395: Display bibliographic data for deleted biblios in holds history (8.04 KB, patch)
2025-04-23 14:38 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 38395: Only embed deleted_biblios for old holds (1.55 KB, patch)
2025-04-23 15:05 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 38395: Only embed deleted_biblios for old holds (1.60 KB, patch)
2025-04-23 20:34 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 38395: Display bibliographic data for deleted biblios in holds history (8.35 KB, patch)
2025-05-01 09:55 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38395: Only embed deleted_biblios for old holds (1.67 KB, patch)
2025-05-01 09:55 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-11-07 15:20:22 UTC
Bug 30648 made Koha retain deleted_biblionumber in reserves and old_reserves, but did not make Koha use that deleted_biblionumber to display a title in holds history.

To recreate:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history, see "No bibliographic record"
 - use a report to look at your hold in old_reserves, confirm your deleted biblionumber is in the table
Comment 1 Nick Clemens (kidclamp) 2025-04-23 14:02:50 UTC
Created attachment 181373 [details] [review]
Bug 38395: Display bibliographic data for deleted biblios in holds history

This patch adds deleted_biblio to the patron holds api and adjsuts the display to
shwo the data for deleted items

To test:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history
 - you see a line with no title or author
 - apply patch, yarn build, restart_all
 - reload patron hold history
 - success, you see deleted title info
 - enable OPACHoldsHistory preference
 - sign in to OPAC as patron
 - confirm holds history shows deleted title info
Comment 2 Roman Dolny 2025-04-23 14:38:25 UTC
Created attachment 181380 [details] [review]
Bug 38395: Display bibliographic data for deleted biblios in holds history

This patch adds deleted_biblio to the patron holds api and adjsuts the display to
shwo the data for deleted items

To test:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history
 - you see a line with no title or author
 - apply patch, yarn build, restart_all
 - reload patron hold history
 - success, you see deleted title info
 - enable OPACHoldsHistory preference
 - sign in to OPAC as patron
 - confirm holds history shows deleted title info

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Andrew Fuerste-Henry 2025-04-23 14:59:30 UTC
This patch makes the page fail when the patron has an active hold on a non-deleted biblio.
Comment 4 Nick Clemens (kidclamp) 2025-04-23 15:05:08 UTC
Created attachment 181388 [details] [review]
Bug 38395: Only embed deleted_biblios for old holds
Comment 5 Roman Dolny 2025-04-23 20:34:36 UTC
Created attachment 181397 [details] [review]
Bug 38395: Only embed deleted_biblios for old holds

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 6 Matt Blenkinsop 2025-05-01 09:55:55 UTC
Created attachment 181824 [details] [review]
Bug 38395: Display bibliographic data for deleted biblios in holds history

This patch adds deleted_biblio to the patron holds api and adjsuts the display to
shwo the data for deleted items

To test:
 - place a hold
 - cancel the hold
 - look in patron hold history, see the title
 - delete the biblio
 - reload patron hold history
 - you see a line with no title or author
 - apply patch, yarn build, restart_all
 - reload patron hold history
 - success, you see deleted title info
 - enable OPACHoldsHistory preference
 - sign in to OPAC as patron
 - confirm holds history shows deleted title info

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 7 Matt Blenkinsop 2025-05-01 09:55:58 UTC
Created attachment 181825 [details] [review]
Bug 38395: Only embed deleted_biblios for old holds

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Comment 8 Katrin Fischer 2025-05-02 06:55:03 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 9 Andrew Fuerste-Henry 2025-05-02 12:06:18 UTC
Can this please be backported to 24.11?
Comment 10 Paul Derscheid 2025-05-26 07:25:19 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05