Bug 30648 made Koha retain deleted_biblionumber in reserves and old_reserves, but did not make Koha use that deleted_biblionumber to display a title in holds history. To recreate: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history, see "No bibliographic record" - use a report to look at your hold in old_reserves, confirm your deleted biblionumber is in the table
Created attachment 181373 [details] [review] Bug 38395: Display bibliographic data for deleted biblios in holds history This patch adds deleted_biblio to the patron holds api and adjsuts the display to shwo the data for deleted items To test: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history - you see a line with no title or author - apply patch, yarn build, restart_all - reload patron hold history - success, you see deleted title info - enable OPACHoldsHistory preference - sign in to OPAC as patron - confirm holds history shows deleted title info
Created attachment 181380 [details] [review] Bug 38395: Display bibliographic data for deleted biblios in holds history This patch adds deleted_biblio to the patron holds api and adjsuts the display to shwo the data for deleted items To test: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history - you see a line with no title or author - apply patch, yarn build, restart_all - reload patron hold history - success, you see deleted title info - enable OPACHoldsHistory preference - sign in to OPAC as patron - confirm holds history shows deleted title info Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
This patch makes the page fail when the patron has an active hold on a non-deleted biblio.
Created attachment 181388 [details] [review] Bug 38395: Only embed deleted_biblios for old holds
Created attachment 181397 [details] [review] Bug 38395: Only embed deleted_biblios for old holds Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 181824 [details] [review] Bug 38395: Display bibliographic data for deleted biblios in holds history This patch adds deleted_biblio to the patron holds api and adjsuts the display to shwo the data for deleted items To test: - place a hold - cancel the hold - look in patron hold history, see the title - delete the biblio - reload patron hold history - you see a line with no title or author - apply patch, yarn build, restart_all - reload patron hold history - success, you see deleted title info - enable OPACHoldsHistory preference - sign in to OPAC as patron - confirm holds history shows deleted title info Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Created attachment 181825 [details] [review] Bug 38395: Only embed deleted_biblios for old holds Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
Pushed for 25.05! Well done everyone, thank you!
Can this please be backported to 24.11?
Nice work everyone! Pushed to 24.11.x for 24.11.05
Depends on bug not in 22.11.x Not backporting to 22.11.x