Summary: | Fix inconsistencies in database update messages | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Installation and upgrade (command-line installer) | Assignee: | David Nind <david> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, jonathan.druart, leo.stoyanov, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes some database update messages to improve their consistency with the database update guidelines.
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Bug Depends on: | 38394 | ||
Bug Blocks: | |||
Attachments: |
Bug 38448: Fix inconsistencies in database update messages
Bug 38448: Fix inconsistencies in database update messages Bug 38448: Fix inconsistencies in database update messages |
Description
Katrin Fischer
2024-11-14 15:19:39 UTC
I'm happy to have a go at this, if it is just a matter of updating the individual db_revs. (In reply to David Nind from comment #1) > I'm happy to have a go at this, if it is just a matter of updating the > individual db_revs. Hi David, yes, the mission would be to make the output messages more standardized. Created attachment 175580 [details] [review] Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Here is a list of the changes and the reason: 1. Consistency with other messages and improve wording: From: "list_borrowers added to $count users with XXX" To: "Added permission 'list_borrowers' to $count users with 'XXX' permissions" 2. Changed the type of message from info (blue) to success (green): From: say_info( $out, "Added column 'service_platformerm_usage_data_providers'" ); To: say_success( $out, "Added column 'service_platformerm_usage_data_providers'" ); 3. Changed the type of message from plain (white) to success (green): From: say $out "Added new system preference 'JobsNotificationMethod'"; To: say_success( $out, "Added new system preference 'JobsNotificationMethod'" ); 4. Consistency with other messages: From: "Added BOOKING_CANCELLATION authorised value category" To: "Added new authorized value category 'BOOKING_CANCELLATION'" 5. Removed 'noisy' message that is not required: say_success( $out, "Updated manage_search_targets permission description" ); 6. Consistency with other messages: From: "Added OAI-PMH:HarvestEmailReport system preference To: "Added new system preference 'OAI-PMH:HarvestEmailReport'" Created attachment 176165 [details] [review] Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com> Thanks Leo for the sign off! Created attachment 176317 [details] [review] Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Leo Stoyanov <leo.stoyanov@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! |